Rpc <> Exex example #8112
Draft
Rpc <> Exex example #8112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
reviewed
May 5, 2024
examples/exex/custom-rpc/src/main.rs
Outdated
| @@ -0,0 +1,111 @@ | |||
| ` | |||
onbjerg
requested changes
May 5, 2024
examples/exex/custom-rpc/src/main.rs
Outdated
Comment on lines
80
to
109
| let filter = Filter::new().select(0u64..).event("ETHBridgeFinalized(address,address,uint256)"); | ||
| let filter_res = self.provider.new_filter(filter).await; | ||
|
|
||
| match filter_res{ | ||
| Ok(id) =>{ | ||
| let data = self.provider.filter_logs(id).await; | ||
| let mut deposit_count = 0; | ||
| match data{ | ||
| Ok(logs) =>{ | ||
| for log in logs{ | ||
| let val = log.log_decode::<L1StandardBridge::ETHBridgeFinalized>().ok(); | ||
|
|
||
| if let Some(finalized_data) = val{ | ||
| // let's see what to do with this data later. | ||
| let da = finalized_data.data(); | ||
| deposit_count += 1; | ||
| } | ||
| } | ||
| Ok(deposit_count) | ||
| }, | ||
| Err(_) =>{ | ||
| Ok(0) | ||
| } | ||
| } | ||
| }, | ||
| Err(_)=>{ | ||
| Ok(0) | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
this is not correct, we want this to ask the exex what the deposit count is, we don't want to calculate it ourselves on each call
examples/exex/custom-rpc/src/main.rs
Outdated
| .await?; | ||
|
|
||
| handle.wait_for_node_exit().await | ||
| }) |
There was a problem hiding this comment.
the exex is missing, pls see the other examples
examples/exex/custom-rpc/src/main.rs
Outdated
Comment on lines
55
to
57
| #[rpc[server, namespace="onDepositCount"]] | ||
| pub trait OpDepositCountExtApi { | ||
| #[method(name = "opdepositCount")] |
There was a problem hiding this comment.
please follow the naming convention of the other namespaces
|
yeah , the exex is missing . I was first trying to get an idea on how to get a custom rpc . |
|
Clarifying that we'd like the ExEx to spawn the RPC in a custom port or path in the JSON-RPC, this is not a task for opening an additional JSON RPC namespace in the same port! |
|
@onbjerg thought? Please ignore the small nits for now. Just looking for more context from u |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8008
I am trying to write a custom rpc to calculate the no of deposits in op bridge . But getting some errors. Can u point me to correct it. Thanks