chore: refactor DefaultStages to take StageConfig
#8173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
A-staged-sync
joshieDo
requested review from
onbjerg,
rkrasiuk,
shekhirin,
mattsse,
Rjected and
gakonst
as code owners
emhane
approved these changes
May 10, 2024
mattsse
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel like
DefaultStagesis in a weird place and building a pipeline has a lot of inertia.We always call it, but end up overriding the stages to pass
StageConfigvalues. In some cases, we don't pass them , even though we should.So proposing
DefaultStagesto take these configuration values in the first place, and let the inner builders populate the initializations