Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move all alloy-compat code to a standalone module #8192

Merged
merged 4 commits into from May 12, 2024
Merged

refactor: move all alloy-compat code to a standalone module #8192

merged 4 commits into from May 12, 2024

Conversation

guha-rahul
Copy link
Contributor

addresses #8168
added the alloy-compact impl from block.rs and header.rs to a new module compat

@guha-rahul guha-rahul requested a review from gakonst as a code owner May 10, 2024 06:09
mattsse
mattsse requested changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty,
pedantic nits

crates/primitives/src/compat/mod.rs Outdated Show resolved Hide resolved
crates/primitives/src/lib.rs Outdated Show resolved Hide resolved
crates/primitives/src/lib.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the C-debt A section of code is hard to understand or change label May 10, 2024
@guha-rahul
Copy link
Contributor Author

guha-rahul commented May 11, 2024 •
edited

@mattsse some feedback on the commits?

@guha-rahul guha-rahul requested a review from mattsse May 11, 2024 14:19
mattsse
mattsse approved these changes May 12, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, ty

only changed the nested mod

@mattsse mattsse enabled auto-merge May 12, 2024 11:14
@mattsse mattsse added this pull request to the merge queue May 12, 2024
Merged via the queue into paradigmxyz:main with commit 487f7e3 May 12, 2024
28 checks passed
Rjected pushed a commit that referenced this pull request May 21, 2024
@guha-rahul @mattsse @Rjected
refactor: move all alloy-compat code to a standalone module (#8192)
fcf5952 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt A section of code is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guha-rahul @mattsse