Make visitor call concreat #653
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #653 +/- ##
============================================
+ Coverage 88.03% 88.16% +0.12%
- Complexity 3466 3582 +116
============================================
Files 149 149
Lines 9151 9452 +301
============================================
+ Hits 8056 8333 +277
- Misses 1095 1119 +24 ☔ View full report in Codecov by Sentry. |
AJenbo
force-pushed
the
visitors
branch
4 times, most recently
from
ca942df
to
dc2dcee
Compare
AJenbo
force-pushed
the
visitors
branch
2 times, most recently
from
3400441
to
e19b240
Compare
AJenbo
force-pushed
the
visitors
branch
12 times, most recently
from
6521174
to
d5460dd
Compare
Instead of relying on a magic function make the analyzers call there specific visitor functions using instanceof in an overwrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on a magic function make the analyzers call there specific visitor functions using instanceof in an overwrite
Type: refactoring
Breaking change: yes
This moves the responsibility of calling type specific visitors to the definer as suggested here: #644
The benefit is that the code can now be evaluated by static analysis since it does not make use of magic methods or run time generated callbacks.
To simplify things further I have also adjusted all
vist*()methods to follow the same base signature so that they can all be used in the same way.This did uncover some cases where ASTNode was assumed bug ASTArtifact given, leading to calls to undefined methods that could have resulted in a fatal error.