Seal up AbstractPHPParser #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJenbo
force-pushed
the
private-AbstractPHPParser
branch
6 times, most recently
from
e308ad8
to
386b97e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #746 +/- ##
============================================
+ Coverage 89.59% 89.61% +0.01%
Complexity 3418 3418
============================================
Files 144 144
Lines 9105 9105
============================================
+ Hits 8158 8159 +1
+ Misses 947 946 -1 ☔ View full report in Codecov by Sentry. |
AJenbo
force-pushed
the
private-AbstractPHPParser
branch
6 times, most recently
from
949e641
to
ff87741
Compare
AJenbo
force-pushed
the
private-AbstractPHPParser
branch
10 times, most recently
from
b900442
to
0a3dfce
Compare
AJenbo
force-pushed
the
private-AbstractPHPParser
branch
from
8e99b7a
to
621e35f
Compare
kylekatarnls
previously approved these changes
May 14, 2024
AJenbo
force-pushed
the
private-AbstractPHPParser
branch
2 times, most recently
from
e2b5910
to
75209d2
Compare
AJenbo
force-pushed
the
private-AbstractPHPParser
branch
10 times, most recently
from
4e05081
to
af15dd4
Compare
AJenbo
force-pushed
the
private-AbstractPHPParser
branch
from
af15dd4
to
136ebe6
Compare
kylekatarnls
approved these changes
May 20, 2024
|
Arh good to have this one in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark functions that do not need to be overwritten as private in order to limit our API surface and what we would need to support going forward. If we need to overwrite any of these in future version of PHP we can expose them then and support them from that point on. The same can be done if this causes issues for down stream, but better to think about what we expose then to expose everything.
This allows us more freedom when refactoring, but also makes analyzers better able to conclude if code could potentially be extended with other input/output or is even unused.