Correct nullable return values #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #821 +/- ##
======================================
Coverage ? 89.67%
Complexity ? 3391
======================================
Files ? 144
Lines ? 9054
Branches ? 0
======================================
Hits ? 8119
Misses ? 935
Partials ? 0 ☔ View full report in Codecov by Sentry. |
AJenbo
force-pushed
the
nullable-returns
branch
9 times, most recently
from
54aea6d
to
f992c34
Compare
kylekatarnls
approved these changes
May 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: refactoring / documentation update
Breaking change: no
This correct a few methods that could return null but was not documented as such.