Fixed _removeConnection where connection was removed but id remained … #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empty in connection list Signed-off-by: Arthur Frederico Neves <arthurfred.neves@gmail.com>
….close(), not sending any event Signed-off-by: Arthur Frederico Neves <arthurfred.neves@gmail.com>
jonasgloning
added a commit
that referenced
this pull request
May 25, 2022
|
Hey @SharkSharp, thanks for the PR! |
jonasgloning
pushed a commit
that referenced
this pull request
May 25, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Feb 25, 2023
## [1.4.8-rc.1](v1.4.7...v1.4.8-rc.1) (2023-02-25) ### Bug Fixes * `close` event was not triggered reliably ([#860](#860)) ([ec1d5ae](ec1d5ae)), closes [#636](#636) * **datachannel:** sending order is now preserved correctly ([18d491a](18d491a)), closes [#746](#746) * **deps:** update dependency @swc/helpers to ^0.4.0 ([a7de8b7](a7de8b7)) * **deps:** update dependency eventemitter3 to v5 ([caf01c6](caf01c6)) * **deps:** update dependency webrtc-adapter to v8 ([431f00b](431f00b)) * **npm audit:** Updates all dependencies that cause npm audit to issue a warning ([6ef5707](6ef5707))
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2023
## [1.5.2-rc.1](v1.5.1...v1.5.2-rc.1) (2023-12-03) ### Bug Fixes * `close` event was not triggered reliably ([#860](#860)) ([ec1d5ae](ec1d5ae)), closes [#636](#636) * **datachannel:** sending order is now preserved correctly ([18d491a](18d491a)), closes [#746](#746) * support Blobs nested in objects ([7956dd6](7956dd6)), closes [#1163](#1163)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 27, 2024
## [1.5.3-rc.1](v1.5.2...v1.5.3-rc.1) (2024-04-27) ### Bug Fixes * `close` event was not triggered reliably ([#860](#860)) ([ec1d5ae](ec1d5ae)), closes [#636](#636) * **datachannel:** sending order is now preserved correctly ([18d491a](18d491a)), closes [#746](#746) * navigator is not defined ([305a180](305a180)) * navigator is not defined. ([6f85dd3](6f85dd3)) * remove need for `unsafe-eval` ([f1857fe](f1857fe))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In _removeConnection, when the connection is removed, it is not checked if there are still active connections on that id, thus leaving an id with no connections in the connection list, which seems wrong to me
In negotiator, when peerConnection.iceConnectionState becomes "disconnected" the method this.connection.close(); is not called, giving no close event in the connection, which seems wrong to me
Signed-off-by: Arthur Frederico Neves arthurfred.neves@gmail.com