Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Vendor OAuth1 from requests-oauthlib #3721

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akx
Copy link
Contributor

@akx akx commented Apr 9, 2024

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

This PR vendors the single file used from requests_oauthlib to avoid an extra dependency on requests_oauthlib itself. The only changes made to the vendored file are mechanical (isort, black) and adding the ISC license header from requests-oauthlib.

@coveralls
Copy link

coveralls commented Apr 9, 2024

Coverage Status

coverage: 95.567% (-0.1%) from 95.681%
when pulling c1eda02 on akx:vendor-requests-oauthlib
into 2e37568 on pennersr:main.

@pennersr
Copy link
Owner

Where you having problems with the existing dependency? Wondering what the advantage is of doing this, as requests-oauthlib seems to be well maintained.

@akx
Copy link
Contributor Author

akx commented Apr 14, 2024

No particular problem, was just looking at dependency chains while looking at routine upgrades for projects.

Seems a waste to have one extra 1K LoC dependency for the single file that's being used from it.

@akx akx force-pushed the vendor-requests-oauthlib branch from 7ea08ec to c1eda02 Compare April 26, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants