Skip to content

Commit

Permalink
MONDRIAN: Migrate bug references from SourceForge to Jira.
Browse files Browse the repository at this point in the history
[git-p4: depot-paths = "//open/mondrian/": change = 12588]
  • Loading branch information
julianhyde committed Apr 10, 2009
1 parent 01fcbba commit 114b988
Show file tree
Hide file tree
Showing 13 changed files with 60 additions and 67 deletions.
6 changes: 3 additions & 3 deletions src/main/mondrian/rolap/RolapStar.java
Expand Up @@ -4,7 +4,7 @@
// Agreement, available at the following URL:
// http://www.opensource.org/licenses/cpl.html.
// Copyright (C) 2001-2002 Kana Software, Inc.
// Copyright (C) 2001-2008 Julian Hyde and others
// Copyright (C) 2001-2009 Julian Hyde and others
// All Rights Reserved.
// You must accept the terms of that agreement to use this software.
//
Expand Down Expand Up @@ -1261,8 +1261,8 @@ public static String createInExpr(
// is unfortunate, and we will fix it some day. For now, create
// a fake column with all of the information needed by the toSql
// method, and a copy of the predicate wrapping that fake column.
if (!Bug.Bug1767775Fixed ||
!Bug.Bug1767779Fixed && predicate.getConstrainedColumn() == null)
if (!Bug.BugMondrian313Fixed ||
!Bug.BugMondrian314Fixed && predicate.getConstrainedColumn() == null)
{
Column column = new Column(datatype) {
public String generateExprString(SqlQuery query) {
Expand Down
6 changes: 3 additions & 3 deletions src/main/mondrian/rolap/StarColumnPredicate.java
Expand Up @@ -3,7 +3,7 @@
// This software is subject to the terms of the Common Public License
// Agreement, available at the following URL:
// http://www.opensource.org/licenses/cpl.html.
// Copyright (C) 2007-2007 Julian Hyde
// Copyright (C) 2007-2009 Julian Hyde
// All Rights Reserved.
// You must accept the terms of that agreement to use this software.
*/
Expand Down Expand Up @@ -86,8 +86,8 @@ public interface StarColumnPredicate extends StarPredicate {
* {@link #toSql(mondrian.rolap.sql.SqlQuery, StringBuilder)}.
*
* <p>todo: remove this method when
* {@link mondrian.util.Bug#Bug1767775Fixed bug 1767776} and
* {@link mondrian.util.Bug#Bug1767779Fixed bug 1767779} are fixed.
* {@link mondrian.util.Bug#BugMondrian313Fixed bug MONDRIAN-313} and
* {@link mondrian.util.Bug#BugMondrian314Fixed bug MONDRIAN-314} are fixed.
*/
StarColumnPredicate cloneWithColumn(RolapStar.Column column);

Expand Down
45 changes: 19 additions & 26 deletions src/main/mondrian/util/Bug.java
Expand Up @@ -3,7 +3,7 @@
// This software is subject to the terms of the Common Public License
// Agreement, available at the following URL:
// http://www.opensource.org/licenses/cpl.html.
// Copyright (C) 2006-2008 Julian Hyde
// Copyright (C) 2006-2009 Julian Hyde
// All Rights Reserved.
// You must accept the terms of that agreement to use this software.
*/
Expand All @@ -25,10 +25,10 @@
public class Bug {
/**
* Whether
* <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=1574942&group_id=35302&atid=414613">bug 1574942, "NON EMPTY when hierarchy's default member is not 'all'"</a>
* <a href="http://jira.pentaho.com/browse/MONDRIAN-229">MONDRIAN-229, "NON EMPTY when hierarchy's default member is not 'all'"</a>
* is fixed.
*/
public static final boolean Bug1574942Fixed = false;
public static final boolean BugMondrian229Fixed = false;

// Properties relating to checkin 7641.
// This is part of the junit test Checkin_7641 that
Expand All @@ -42,67 +42,60 @@ public class Bug {

/**
* Whether
* <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=1530543&group_id=35302&atid=414613">bug 1530543, "IS EMPTY and IS NULL"</a>
* <a href="http://jira.pentaho.com/browse/MONDRIAN-207">MONDRIAN-207, "IS EMPTY and IS NULL"</a>
* is fixed.
*/
public static final boolean Bug1530543Fixed = false;
public static final boolean BugMondrian207Fixed = false;

/**
* Whether
* <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=2076407&group_id=35302&atid=414613">bug Bug2076407Fixed, "Make Native NonEmpty consistant with MSAS"</a>
* <a href="http://jira.pentaho.com/browse/MONDRIAN-446">bug MONDRIAN-446, "Make Native NonEmpty consistant with MSAS"</a>
* is fixed.
*/
public static final boolean Bug2076407Fixed = false;
public static final boolean BugMondrian446Fixed = false;

/**
* Whether
* <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=1767775&group_id=35302&atid=414613">bug 1767775, "Predicate references RolapStar.Column when used in AggStar"</a>
* <a href="http://jira.pentaho.com/browse/MONDRIAN-313">bug MONDRIAN-313, "Predicate references RolapStar.Column when used in AggStar"</a>
* is fixed.
*/
public static final boolean Bug1767775Fixed = false;
public static final boolean BugMondrian313Fixed = false;

/**
* Whether
* <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=1767779&group_id=35302&atid=414613">bug 1767779, "Predicate sometimes has null RolapStar.Column"</a>
* <a href="http://jira.pentaho.com/browse/MONDRIAN-314">bug MONDRIAN-314, "Predicate sometimes has null RolapStar.Column"</a>
* is fixed.
*/
public static final boolean Bug1767779Fixed = false;
public static final boolean BugMondrian314Fixed = false;

/**
* Whether
* <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=1791609&group_id=35302&atid=414613">bug 1791609, "CrossJoin no empty optimizer eliminates calculated member"</a>
* <a href="http://jira.pentaho.com/browse/MONDRIAN-328">bug MONDRIAN-328, "CrossJoin no empty optimizer eliminates calculated member"</a>
* is fixed.
*/
public static final boolean Bug1791609Fixed = false;
public static final boolean BugMondrian328Fixed = false;

/**
* Whether
* <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=1867953&group_id=35302&atid=414613">bug 1867953, "Aggregate Tables not working with Shared Dimensions"</a>
* <a href="http://jira.pentaho.com/browse/MONDRIAN-361">bug MONDRIAN-361, "Aggregate Tables not working with Shared Dimensions"</a>
* is fixed.
*
*/
public static final boolean Bug1867953Fixed = false;
public static final boolean BugMondrian361Fixed = false;

/**
* Whether
* <a href="https://sourceforge.net/tracker/index.php?func=detail&aid=1888821&group_id=35302&atid=414613">bug 1888821, "Non Empty Crossjoin fails to enforce role access"</a>
* <a href="http://jira.pentaho.com/browse/MONDRIAN-486">bug MONDRIAN-486, "HighCardinalityTest test cases disabled"</a>
* is fixed.
*/
public static final boolean Bug1888821Fixed = false;
public static final boolean BugMondrian486Fixed = false;

/**
* Whether
* <a href="https://sourceforge.net/tracker/index.php?func=detail&aid=2446228&group_id=35302&atid=414613">bug 2446228, "HighCardinalityTest test cases disabled"</a>
* <a href="http://jira.pentaho.com/browse/MONDRIAN-503">bug MONDRIAN-503, "RolapResultTest disabled"</a>
* is fixed.
*/
public static final boolean Bug2446228Fixed = false;

/**
* Whether
* <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=2583015&group_id=35302&atid=414613">bug 2583015, "RolapResultTest disabled"</a>
* is fixed.
*/
public static final boolean Bug2583015Fixed = false;
public static final boolean BugMondrian503Fixed = false;

/**
* Returns whether to avoid a test because the memory monitor may cause it
Expand Down
6 changes: 3 additions & 3 deletions testsrc/main/mondrian/olap/fun/FunctionTest.java
Expand Up @@ -513,7 +513,7 @@ public void testIsEmpty()
// Not a runtime exception.
assertBooleanExprReturns("[Gender].CurrentMember.Parent.NextMember IS NULL", true);

if (!Bug.Bug1530543Fixed) {
if (!Bug.BugMondrian207Fixed) {
return;
}

Expand Down Expand Up @@ -7672,8 +7672,8 @@ public void testYtd() {

/**
* Testcase for
* <a href="https://sourceforge.net/tracker/?func=detail&atid=414613&aid=2150537&group_id=35302">
* bug 2150537, "error deducing type of Ytd/Qtd/Mtd functions within
* <a href="http://jira.pentaho.com/browse/MONDRIAN-458">
* bug MONDRIAN-458, "error deducing type of Ytd/Qtd/Mtd functions within
* Generate"</a>.
*/
public void testGeneratePlusXtd() {
Expand Down
10 changes: 5 additions & 5 deletions testsrc/main/mondrian/rolap/HighDimensionsTest.java
Expand Up @@ -3,7 +3,7 @@
// This software is subject to the terms of the Common Public License
// Agreement, available at the following URL:
// http://www.opensource.org/licenses/cpl.html.
// Copyright (C) 2006-2008 Julian Hyde
// Copyright (C) 2006-2009 Julian Hyde
// All Rights Reserved.
// You must accept the terms of that agreement to use this software.
*/
Expand Down Expand Up @@ -74,7 +74,7 @@ public void testBug1971406() throws Exception {


public void testPromotionsTwoDimensions() throws Exception {
if (!Bug.Bug2446228Fixed) {
if (!Bug.BugMondrian486Fixed) {
return;
}
execHighCardTest("select {[Measures].[Unit Sales]} on columns,\n"
Expand All @@ -85,7 +85,7 @@ public void testPromotionsTwoDimensions() throws Exception {


public void testHead() throws Exception {
if (!Bug.Bug2446228Fixed) {
if (!Bug.BugMondrian486Fixed) {
return;
}
execHighCardTest("select {[Measures].[Unit Sales]} on columns,\n"
Expand Down Expand Up @@ -135,7 +135,7 @@ public void testTopCount() throws Exception {


public void testNonEmpty() throws Exception {
if (!Bug.Bug2446228Fixed) {
if (!Bug.BugMondrian486Fixed) {
return;
}
execHighCardTest("select {[Measures].[Unit Sales]} on columns,\n"
Expand All @@ -145,7 +145,7 @@ public void testNonEmpty() throws Exception {
}

public void testFilter() throws Exception {
if (!Bug.Bug2446228Fixed) {
if (!Bug.BugMondrian486Fixed) {
return;
}
execHighCardTest("select [Measures].[Unit Sales] on columns, "
Expand Down
7 changes: 3 additions & 4 deletions testsrc/main/mondrian/rolap/NonEmptyTest.java
Expand Up @@ -36,7 +36,6 @@
import mondrian.rolap.sql.TupleConstraint;
import mondrian.test.SqlPattern;
import mondrian.test.TestContext;
import mondrian.test.PropertySaver;
import mondrian.util.Bug;
import mondrian.spi.Dialect;

Expand Down Expand Up @@ -2625,7 +2624,7 @@ public void testCjUnionEnumCalcMembers() {
* member of a hierarchy is not 'all' or the first child.
*/
public void testNonEmptyWithWeirdDefaultMember() {
if (!Bug.Bug1574942Fixed) {
if (!Bug.BugMondrian229Fixed) {
return;
}
TestContext testContext = TestContext.createSubstitutingCube(
Expand Down Expand Up @@ -3123,7 +3122,7 @@ public void testDependentSlicerMemberNative() {
* member".
*/
public void testBug1791609NonEmptyCrossJoinEliminatesCalcMember() {
if (!Bug.Bug1791609Fixed) {
if (!Bug.BugMondrian328Fixed) {
return;
}
// From the bug:
Expand Down Expand Up @@ -3276,7 +3275,7 @@ public void testNonEmptyLevelMembers() {
"Row #1: 142,277.07\n" +
"Row #1: 263,793.22\n"));

if (Bug.Bug2076407Fixed) {
if (Bug.BugMondrian446Fixed) {
MondrianProperties.instance().EnableNativeNonEmpty.set(true);
assertQueryReturns(
"WITH MEMBER [Measures].[One] AS '1' " +
Expand Down
5 changes: 3 additions & 2 deletions testsrc/main/mondrian/rolap/aggmatcher/BUG_1541077.java
Expand Up @@ -3,7 +3,7 @@
// This software is subject to the terms of the Common Public License
// Agreement, available at the following URL:
// http://www.opensource.org/licenses/cpl.html.
// Copyright (C) 2005-2008 Julian Hyde and others
// Copyright (C) 2005-2009 Julian Hyde and others
// All Rights Reserved.
// You must accept the terms of that agreement to use this software.
*/
Expand All @@ -14,7 +14,8 @@

/**
* Testcase for
* <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=1541077&group_id=35302&atid=414613">bug 1541077</a>
* <a href="http://jira.pentaho.com/browse/MONDRIAN-214">MONDRIAN-214</a>
* (formerly SourceForge bug 1541077)
* and a couple of other aggregate table ExplicitRecognizer conditions.
*
* @author Richard M. Emberson
Expand Down
6 changes: 3 additions & 3 deletions testsrc/main/mondrian/test/AccessControlTest.java
Expand Up @@ -3,7 +3,7 @@
// This software is subject to the terms of the Common Public License
// Agreement, available at the following URL:
// http://www.opensource.org/licenses/cpl.html.
// Copyright (C) 2003-2008 Julian Hyde
// Copyright (C) 2003-2009 Julian Hyde
// All Rights Reserved.
// You must accept the terms of that agreement to use this software.
//
Expand Down Expand Up @@ -1387,8 +1387,8 @@ private void checkBug2031158() {
/**
* Tests that hierarchy-level access control works on a virtual cube.
* See bug
* <a href="https://sourceforge.net/tracker/index.php?func=detail&aid=2141337&group_id=35302&atid=414613">
* 2141337, "Roles and virtual cubes"</a>.
* <a href="http://jira.pentaho.com/browse/MONDRIAN-456">
* MONDRIAN-456, "Roles and virtual cubes"</a>.
*/
public void testVirtualCube() {
TestContext testContext = TestContext.create(
Expand Down
4 changes: 2 additions & 2 deletions testsrc/main/mondrian/test/Main.java
Expand Up @@ -4,7 +4,7 @@
// Agreement, available at the following URL:
// http://www.opensource.org/licenses/cpl.html.
// Copyright (C) 1998-2002 Kana Software, Inc.
// Copyright (C) 2001-2008 Julian Hyde and others
// Copyright (C) 2001-2009 Julian Hyde and others
// All Rights Reserved.
// You must accept the terms of that agreement to use this software.
//
Expand Down Expand Up @@ -254,7 +254,7 @@ public static Test suite() throws Exception {
addTest(suite, RolapAxisTest.class);
addTest(suite, MemberHelperTest.class);
addTest(suite, CrossJoinTest.class);
if (Bug.Bug2583015Fixed) {
if (Bug.BugMondrian503Fixed) {
addTest(suite, RolapResultTest.class);
}
addTest(suite, ConstantCalcTest.class);
Expand Down
6 changes: 3 additions & 3 deletions testsrc/main/mondrian/test/MultipleHierarchyTest.java
Expand Up @@ -3,7 +3,7 @@
// This software is subject to the terms of the Common Public License
// Agreement, available at the following URL:
// http://www.opensource.org/licenses/cpl.html.
// Copyright (C) 2005-2006 Julian Hyde
// Copyright (C) 2005-2009 Julian Hyde
// All Rights Reserved.
// You must accept the terms of that agreement to use this software.
*/
Expand Down Expand Up @@ -115,8 +115,8 @@ public void testCalcMember() {
}

/**
* Tests <a href="https://sourceforge.net/tracker/?func=detail&atid=414613&aid=1501533&group_id=35302">
* bug 1501533, "Properties not working with multiple hierarchies"</a>.
* Tests <a href="http://jira.pentaho.com/browse/MONDRIAN-191">
* bug MONDRIAN-191, "Properties not working with multiple hierarchies"</a>.
*/
public void testProperty() {
TestContext testContext = TestContext.createSubstitutingCube("Sales",
Expand Down
12 changes: 6 additions & 6 deletions testsrc/main/mondrian/test/SchemaTest.java
Expand Up @@ -243,8 +243,8 @@ public void testHierarchyBadDefaultMember() {
* <p>Tests that an error is issued if two dimensions use the same table via
* different drill-paths and do not use a different alias. If this error is
* not issued, the generated SQL can be missing a join condition, as in
* <a href="https://sourceforge.net/tracker/?func=detail&atid=414613&aid=1583462&group_id=35302">
* Bug 1583462, "Mondrian generates invalid SQL"</a>.
* <a href="http://jira.pentaho.com/browse/MONDRIAN-236">
* Bug MONDRIAN-236, "Mondrian generates invalid SQL"</a>.
*/
public void testDuplicateTableAlias() {
final TestContext testContext = TestContext.createSubstitutingCube(
Expand Down Expand Up @@ -558,7 +558,7 @@ public void testSnowflakeHierarchyValidationNotNeeded() {
// due to a known limitation
if ((MondrianProperties.instance().ReadAggregates.get() ||
MondrianProperties.instance().UseAggregates.get())
&& !Bug.Bug1867953Fixed) {
&& !Bug.BugMondrian361Fixed) {
return;
}

Expand Down Expand Up @@ -1401,8 +1401,8 @@ public void testInvalidAggregator() {

/**
* Testcase for
* <a href="https://sourceforge.net/tracker/?func=detail&atid=414613&aid=1583462&group_id=35302">
* Bug 1721514, "'unknown usage' messages"</a>.
* <a href="http://jira.pentaho.com/browse/MONDRIAN-291">
* Bug MONDRIAN-291, "'unknown usage' messages"</a>.
*/
public void testUnknownUsages() {
if (!MondrianProperties.instance().ReadAggregates.get()) {
Expand Down Expand Up @@ -1829,7 +1829,7 @@ public void testCubeWithOneCalcMeasure() {
* this test triggers an exception out of the aggregate table manager
*/
public void testAggTableSupportOfSharedDims() {
if (Bug.Bug1867953Fixed) {
if (Bug.BugMondrian361Fixed) {
TestContext testContext = TestContext.create(
null,
"<Cube name=\"Sales Two Dimensions\">\n" +
Expand Down
10 changes: 5 additions & 5 deletions testsrc/main/mondrian/test/TestCalculatedMembers.java
Expand Up @@ -4,7 +4,7 @@
// Agreement, available at the following URL:
// http://www.opensource.org/licenses/cpl.html.
// Copyright (C) 2002-2002 Kana Software, Inc.
// Copyright (C) 2002-2008 Julian Hyde and others
// Copyright (C) 2002-2009 Julian Hyde and others
// All Rights Reserved.
// You must accept the terms of that agreement to use this software.
//
Expand Down Expand Up @@ -641,8 +641,8 @@ public void testCalcMemberWithQuote() {
}

/**
* Testcase for <a href="https://sourceforge.net/tracker/index.php?func=detail&aid=1410383&group_id=35302&atid=414613">
* bug 1410383, "error if calc member in schema file contains single quotes"</a>.
* Testcase for bug <a href="http://jira.pentaho.com/browse/MONDRIAN-137">
* MONDRIAN-137, "error if calc member in schema file contains single quotes"</a>.
*/
public void testQuoteInCalcMember() {
final String cubeName = "Sales_Bug1410383";
Expand Down Expand Up @@ -793,8 +793,8 @@ public void testFormatString() {
}

/**
* Testcase for <a href="https://sourceforge.net/tracker/index.php?func=detail&aid=1669104&group_id=35302&atid=414613">
* bug 1669104, Negative Solve Orders broken</a>.
* Testcase for <a href="http://jira.pentaho.com/browse/MONDRIAN-263">
* bug MONDRIAN-263, Negative Solve Orders broken</a>.
*/
public void testNegativeSolveOrder() {
// Negative solve orders are OK.
Expand Down

0 comments on commit 114b988

Please sign in to comment.