MONDRIAN: Reverts a prior modification which enabled allowsJoinOn(). …

…Some issues were discovered and logged as MONDRIAN-955

Also extends the documentation of RolapConnectionProperties.Catalogcontent, as proposed by a community member. It now specifies the rules which apply to escaping quotation marks.

[git-p4: depot-paths = "//open/mondrian/": change = 14375]

src/main/mondrian/rolap/RolapConnectionProperties.java

@@ -71,7 +71,14 @@ public enum RolapConnectionProperties {
      * cubes, hierarchies, and so forth.
      * Catalogs are described in <a target="_top"
      * href="{@docRoot}/../schema.html">the Schema Guide</a>.
-     * See also {@link #Catalog}.
+     *
+     * <p>When using this property, quote its value with either single or
+     * double quotes, then escape all occurrences of that character within the
+     * catalog content by using double single/double quotes. ie:
+     *
+     * <p>&nbsp;&nbsp;CatalogContent="&lt;Schema name=""My Schema""/&gt;"
+     *
+     * <p>See also {@link #Catalog}.
      */
     CatalogContent,
 

src/main/mondrian/spi/impl/InfobrightDialect.java

@@ -99,12 +99,6 @@ public boolean supportsMultiValueInExpr() {
         // does not.
         return false;
     }
-
-    public boolean allowsJoinOn() {
-        // Infobright performs much better when using joins in the
-        // FROM clause rather than joining the tables in the WHERE clause.
-        return true;
-    }
 }
 
 // End InfobrightDialect.java