Skip to content

Commit

Permalink
MONDRIAN
Browse files Browse the repository at this point in the history
   Back out change the part of change 8110 that
   disabled all drillthroughts in virtual cubes.

[git-p4: depot-paths = "//open/mondrian/": change = 8807]
  • Loading branch information
Richard Emberson committed Mar 1, 2007
1 parent 8a4f45c commit 6cdce05
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
4 changes: 0 additions & 4 deletions src/main/mondrian/rolap/RolapCell.java
Expand Up @@ -121,10 +121,6 @@ public int getDrillThroughCount() {
* @return true if can drill through
*/
public boolean canDrillThrough() {
// Cannot drill through query based on virtual cube.
if (((RolapCube) result.getCube()).isVirtual()) {
return false;
}
// get current members
final Member[] currentMembers = getMembers();
// First member is the measure, test if it is stored measure, return
Expand Down
6 changes: 3 additions & 3 deletions testsrc/main/mondrian/test/DrillThroughTest.java
Expand Up @@ -332,15 +332,15 @@ public void testDrillThroughDupKeys() {
"order by `time_by_day`.`the_year` ASC, `store_ragged`.`store_id` ASC, `store`.`store_id` ASC";
getTestContext().assertSqlEquals(expectedSql, sql);
}

/**
* Tests that cells in a virtual cube say they cannot be drilled through.
* Tests that cells in a virtual cube say they can be drilled through.
*/
public void testDrillThroughVirtualCube() {
Result result = executeQuery(
"SELECT {[Gender]} on 0, {[Customers]} on 1 from [Warehouse and Sales]");
assertFalse(result.getCell(new int[] {0, 0}).canDrillThrough());
assertTrue(result.getCell(new int[] {0, 0}).canDrillThrough());
}

}

// End DrillThroughTest.java

0 comments on commit 6cdce05

Please sign in to comment.