MONDRIAN: Native SQL Optimization does not work with Virtual Cubes - …

…so these are disabled for now.

[git-p4: depot-paths = "//open/mondrian/": change = 5733]

src/main/mondrian/rolap/RolapNativeCrossJoin.java

@@ -64,6 +64,8 @@ protected boolean isStrict() {
     NativeEvaluator createEvaluator(RolapEvaluator evaluator, FunDef fun, Exp[] args) {
         if (!isEnabled())
             return null;
+        if (!NonEmptyCrossJoinConstraint.isValidContext(evaluator))
+            return null;
 
         // join with fact table will always filter out those members
         // that dont have a row in the fact table

src/main/mondrian/rolap/RolapNativeFilter.java

@@ -71,6 +71,9 @@ NativeEvaluator createEvaluator(RolapEvaluator evaluator, FunDef fun, Exp[] args
         if (!isEnabled()) {
             return null;
         }
+        if (!FilterConstraint.isValidContext(evaluator)) {
+            return null;
+        }
         // is this "Filter(<set>, <numeric expr>)"
         String funName = fun.getName();
         if (!"Filter".equalsIgnoreCase(funName)) {

src/main/mondrian/rolap/RolapNativeTopCount.java

@@ -82,6 +82,10 @@ protected boolean isStrict() {
     NativeEvaluator createEvaluator(RolapEvaluator evaluator, FunDef fun, Exp[] args) {
         if (!isEnabled())
             return null;
+        if (!TopCountConstraint.isValidContext(evaluator)) {
+            return null;
+        }
+
         // is this "TopCount(<set>, <count>, [<numeric expr>])"
         String funName = fun.getName();
         if ("TopCount".equalsIgnoreCase(funName)) {

src/main/mondrian/rolap/SqlConstraintFactory.java

@@ -36,13 +36,13 @@ public static final SqlConstraintFactory instance() {
     }
 
     public MemberChildrenConstraint getMemberChildrenConstraint(Evaluator context) {
-        if (!enabled || context == null)
+        if (!enabled || !SqlContextConstraint.isValidContext(context))
             return DefaultMemberChildrenConstraint.instance();
         return new SqlContextConstraint((RolapEvaluator) context, false);
     }
 
     public TupleConstraint getLevelMembersConstraint(Evaluator context) {
-        if (!enabled || context == null)
+        if (!enabled || !SqlContextConstraint.isValidContext(context))
             return DefaultTupleConstraint.instance();
         return new SqlContextConstraint((RolapEvaluator) context, false);
     }

src/main/mondrian/rolap/SqlConstraintUtils.java

@@ -64,6 +64,7 @@ public static void addContextConstraint(
         CellRequest request =
                 RolapAggregationManager.makeRequest(members, false);
         if (request == null) {
+            assert !strict : "CellRequest is null - why?";
             // One or more of the members was null or calculated, so the
             // request is impossible to satisfy.
             return;
@@ -107,12 +108,16 @@ private static boolean containsCalculatedMember(Member[] members) {
     /**
      * Ensures that the table of <code>level</code> is joined to the fact table
      */
-    public static void joinLevelTableToFactTable(SqlQuery sqlQuery, RolapCube cube,
+    public static void joinLevelTableToFactTable(SqlQuery sqlQuery, Evaluator e,
             RolapLevel level) {
+        RolapCube cube = (RolapCube) e.getCube();
+        Util.assertTrue(!cube.isVirtual());
         RolapStar star = cube.getStar();
         Map mapLevelToColumnMap = star.getMapLevelToColumn(cube);
         RolapStar.Column starColumn = (RolapStar.Column) mapLevelToColumnMap.get(level);
+        Util.assertTrue(starColumn != null);
         RolapStar.Table table = starColumn.getTable();
+        Util.assertTrue(table != null);
         table.addToFrom(sqlQuery, false, true);
     }
 

src/main/mondrian/rolap/SqlContextConstraint.java

@@ -43,6 +43,18 @@ public class SqlContextConstraint implements MemberChildrenConstraint,
     private Evaluator evaluator;
     private boolean strict;
 
+    /**
+     * @return false if this contstraint will not work for the current context
+     */
+    public static boolean isValidContext(Evaluator context) {
+        if (context == null)
+            return false;
+        RolapCube cube = (RolapCube) context.getCube();
+        if (cube.isVirtual())
+            return false;
+        return true;
+    }
+
    /**
     * @param strict defines the behaviour if the evaluator context
     * contains calculated members. If true, an exception is thrown,
@@ -105,8 +117,7 @@ protected boolean isJoinRequired() {
     public void addLevelConstraint(SqlQuery sqlQuery, RolapLevel level) {
         if (!isJoinRequired())
             return;
-        RolapCube cube = (RolapCube) evaluator.getCube();
-        SqlConstraintUtils.joinLevelTableToFactTable(sqlQuery, cube, level);
+        SqlConstraintUtils.joinLevelTableToFactTable(sqlQuery, evaluator, level);
     }
 
     public MemberChildrenConstraint getMemberChildrenConstraint(RolapMember parent) {

testsrc/main/mondrian/rolap/NonEmptyTest.java

@@ -47,6 +47,19 @@ public class NonEmptyTest extends FoodMartTestCase {
     private static Logger logger = Logger.getLogger(NonEmptyTest.class);
     SqlConstraintFactory scf = SqlConstraintFactory.instance();
 
+    /**
+     * must not use native sql optimization because it chooses the wrong RolapStar
+     * in SqlContextConstraint/SqlConstraintUtils.
+     * Test ensures that no exception is thrown.
+     */
+    public void testVirtualCube() throws Exception {
+        TestCase c = new TestCase(99, 3,
+                "select NON EMPTY {[Measures].[Unit Sales], [Measures].[Warehouse Sales]} ON COLUMNS, " +
+                "NON EMPTY [Product].[All Products].Children ON ROWS " +
+                "from [Warehouse and Sales]");
+        c.run();
+    }
+
     public void testNativeFilter() {
         if (!MondrianProperties.instance().EnableNativeFilter.get()) {
             return;