Skip to content

Commit

Permalink
MONDRIAN: Observe internalType when accessing parent-child hierarchies.
Browse files Browse the repository at this point in the history
[git-p4: depot-paths = "//open/mondrian/": change = 14575]
  • Loading branch information
julianhyde committed Aug 30, 2011
1 parent 9d51a44 commit da23f73
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/main/mondrian/rolap/SqlMemberSource.java
Expand Up @@ -1121,7 +1121,7 @@ private Pair<String, List<SqlStatement.Type>> makeChildMemberSql_PCRoot(
sqlQuery.addWhere(condition.toString());
hierarchy.addToFrom(sqlQuery, level.getKeyExp());
String childId = level.getKeyExp().getExpression(sqlQuery);
sqlQuery.addSelectGroupBy(childId, null);
sqlQuery.addSelectGroupBy(childId, level.getInternalType());
hierarchy.addToFrom(sqlQuery, level.getOrdinalExp());
String orderBy = level.getOrdinalExp().getExpression(sqlQuery);
sqlQuery.addOrderBy(orderBy, true, false, true);
Expand Down Expand Up @@ -1183,7 +1183,7 @@ private Pair<String, List<SqlStatement.Type>> makeChildMemberSqlPC(

hierarchy.addToFrom(sqlQuery, level.getKeyExp());
String childId = level.getKeyExp().getExpression(sqlQuery);
sqlQuery.addSelectGroupBy(childId, null);
sqlQuery.addSelectGroupBy(childId, level.getInternalType());
hierarchy.addToFrom(sqlQuery, level.getOrdinalExp());
String orderBy = level.getOrdinalExp().getExpression(sqlQuery);
sqlQuery.addOrderBy(orderBy, true, false, true);
Expand Down
3 changes: 2 additions & 1 deletion src/main/mondrian/rolap/SqlTupleReader.java
Expand Up @@ -991,7 +991,8 @@ protected void addLevelMemberSql(
hierarchy.addToFrom(sqlQuery, parentExp);
}
String parentSql = parentExp.getExpression(sqlQuery);
sqlQuery.addSelectGroupBy(parentSql, null);
sqlQuery.addSelectGroupBy(
parentSql, currLevel.getInternalType());
if (whichSelect == WhichSelect.LAST
|| whichSelect == WhichSelect.ONLY)
{
Expand Down

0 comments on commit da23f73

Please sign in to comment.