Bucket listing support #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkwolfe
commented
Feb 11, 2013
alexkwolfe
commented
- Bucket listing can now be retrieved
- Bucket listing tests
- Updated to em-http-request 1.0.x series
- Replaced EM::MockHttpRequest, which is no longer available, with webmock
- Reduced test timeouts from 1s to 0.1s for faster test runs
- Added parser option to Request for parsing S3 responses
- Use gemspec for test dependencies
…e in the current stable release. Moved to latest bundler.
…ponding to #call. Added XML parsing to Bucket. Parsed bucket list is provided in response instead of raw XML string. Added Bucket tests.
|
Any thoughts on this? What will it take to get this merged? |
|
Would it be possible to get some feedback on this? We've had this code up and running in production for months and it's solid. Possible to get it merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.