Add official support for Python 3.10 and 3.11 #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like Python 3.5 & 3.6 are no longer available on latest
The former is no longer maintained and has some known issues with Python 3.9+
browniebroke
commented
Dec 20, 2022
| @@ -7,10 +7,11 @@ on: [push, pull_request] | |||
|
|
|||
| jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-20.04 | |||
There was a problem hiding this comment.
It's no longer possible to install Python 3.5 and 3.6 on ubuntu-latest which now points to 22.04. They are both EOL so it's probably time to drop support for them, but that feels out of scope of this change.
Comment on lines
+26
to
+49
| def ok_(expr, msg=None): | ||
| """ | ||
| Shorthand for assert. | ||
|
|
||
| Copied from Nose. | ||
| """ | ||
| if not expr: | ||
| raise AssertionError(msg) | ||
|
|
||
|
|
||
| def eq_(a, b, msg=None): | ||
| """ | ||
| Shorthand for 'assert a == b, "%r != %r" % (a, b). | ||
|
|
||
| Copied from Nose. | ||
| """ | ||
| if not a == b: | ||
| raise AssertionError(msg or "%r != %r" % (a, b)) | ||
|
|
||
|
|
||
| def assert_raises(exc_class, func, *args): | ||
| """Compatibility with Nose API for pytest.""" | ||
| with pytest.raises(exc_class): | ||
| func(*args) |
There was a problem hiding this comment.
These provide compatibility with Nose APIs. I can replace their usage in this file with direct pytest equivalent if you prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main blocker were the test runner, nose which is no longer maintained and has several open issues for recent versions of Python:
I've replaced nose test runner by pytest (which is widely used in the Python community), let me know if you disagree with this choice, and if you prefer another alternative.
Related: #265