New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pyplot strong dependency #38
Merged
Merged
Commits on Mar 29, 2023
-
Nicolau Leal Werneck committed
Mar 29, 2023 Configuration menu - View commit details
-
Copy full SHA for 61eef92 - Browse repository at this point
Copy the full SHA 61eef92View commit details
Commits on Jul 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5abae59 - Browse repository at this point
Copy the full SHA 5abae59View commit details
Commits on Nov 20, 2023
-
work on removing the PyPlot hard dependency
- restore compatibility with Julia <1.9 by re-introducing the PyPlot dependency (will be ignored on newer Julia versions) and hard including the extension of weakdeps are not available - move ransacdemo.jl into the extension module - add to README.md how to get plotting back on new Julia - remove the plotting.jl stub, where the functions that extensions need to implement were declared.
Configuration menu - View commit details
-
Copy full SHA for 2c66f7c - Browse repository at this point
Copy the full SHA 2c66f7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1620d15 - Browse repository at this point
Copy the full SHA 1620d15View commit details -
use Requires.jl to make weak dependencies work
Based on https://pkgdocs.julialang.org/v1/creating-packages/#Backwards-compatibility this uses Requires.jl to bring the weak dependency feature to Julia <1.9
Configuration menu - View commit details
-
Copy full SHA for fb36d68 - Browse repository at this point
Copy the full SHA fb36d68View commit details -
move plotting.jl back in... extensions cannot add new functions, so we already need to define them in a stub that raises an error. We should think about what to export here.
Configuration menu - View commit details
-
Copy full SHA for 10a1487 - Browse repository at this point
Copy the full SHA 10a1487View commit details
Commits on Nov 21, 2023
-
really remove PyPlot dependency
When using Requires and/or package extensions, the PyPlot dependency is not needed anymore. I guess I just forgot to take it out..
Configuration menu - View commit details
-
Copy full SHA for 76808d7 - Browse repository at this point
Copy the full SHA 76808d7View commit details
Commits on Dec 27, 2023
-
By requiring a higher Julia version, the package extension mechanism will be available and can be used always (no need for Requires.jl anymore). This makes the implementation easier. The `get_plot_backend()` function is still contained to avoid method overwrite warnings. Usually, a package extension does type piracy and dispatches on a new type. We only have the demo functions, which cannot dispatch on the type. This now can be extended to different plotting backends (Makie for example), which in turn could be selected in the `get_plot_backend()` function.
Configuration menu - View commit details
-
Copy full SHA for 5084e4c - Browse repository at this point
Copy the full SHA 5084e4cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.