Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Continuous Distribution and Continuous Factor #815

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ankurankan
Copy link
Member

@ankurankan ankurankan commented Jan 4, 2017

  • New BaseDistribution Class
  • New CustomDistribution Class
  • Refactor old ContinuousFactor Class

@coveralls
Copy link

coveralls commented Jan 4, 2017

Coverage Status

Coverage decreased (-0.9%) to 95.32% when pulling 6f45aa5 on ankurankan:issue/782 into 5d885cb on pgmpy:dev.

@coveralls
Copy link

coveralls commented Jan 4, 2017

Coverage Status

Coverage decreased (-0.8%) to 95.432% when pulling b791b76 on ankurankan:issue/782 into 5d885cb on pgmpy:dev.

@yashu-seth
Copy link
Member

yashu-seth commented Jan 5, 2017

@ankurankan I think methods like reduce, marginalize etc. should be in the base distribution not in the custom distribution. There can be cases where I have a different (better) implementation for a particular method but I want the other methods to be inherited.

For example, if we define a gamma distribution and we know the direct results for reducing a multivariate gamma distribution we can implement it by overriding it. But for its other methods, for example product we want the default behavior where the PDFs get multiplied, then we would want to inherit it from the base distribution.

@ankurankan
Copy link
Member Author

ankurankan commented Jan 10, 2017

@yashu-seth Yes you are right. Also would you like to take over this from here ? I will be quite busy with my exams for the next couple of weeks.

@yashu-seth
Copy link
Member

@ankurankan Okay. I will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants