Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use aeson's decode to parse LBS.ByteString #16

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Use aeson's decode to parse LBS.ByteString #16

merged 1 commit into from
Jun 9, 2023

Conversation

phadej
Copy link
Owner

@phadej phadej commented Jun 9, 2023

ping @RyanGlScott. Similar change is probably good idea to do in lens-aeson too.

@phadej phadej merged commit 275a46d into master Jun 9, 2023
9 checks passed
@phadej phadej deleted the encode-decode branch June 9, 2023 20:58
@RyanGlScott
Copy link

Presumably, aeson's decode function is built on top of the same attoparsec functionality that was previously used here?

@phadej
Copy link
Owner Author

phadej commented Jun 9, 2023

@RyanGlScott currently yes, but next aeson release will use different implementation (faster, semantically equivalent).

RyanGlScott added a commit to lens/lens-aeson that referenced this pull request Jun 9, 2023
@RyanGlScott
Use aeson's decode to parse ByteStrings
4894b24 
This paves the way to use a more efficient version of `decode` in an upcoming
`aeson` release.

This mirrors a similar change to `aeson-optics` in phadej/aeson-optics#16.
@RyanGlScott RyanGlScott mentioned this pull request Jun 9, 2023
Merged
@RyanGlScott
Copy link

Ah, that makes sense.

I've submitted a corresponding lens-aeson PR in lens/lens-aeson#54.

RyanGlScott added a commit to lens/lens-aeson that referenced this pull request Jun 9, 2023
@RyanGlScott
Use aeson's decode to parse ByteStrings
13fbf5d 
This paves the way to use a more efficient version of `decode` in an upcoming
`aeson` release.

This mirrors a similar change to `aeson-optics` in phadej/aeson-optics#16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phadej @RyanGlScott