Fix grammar and inconsistent receiver names #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <adrian@tetrate.io>
|
Sorry I overlooked this PR! I'm only on mobile right now, I'll have a look on the next days. |
philippgille
approved these changes
Jun 13, 2024
| @@ -56,7 +56,7 @@ func main() { | |||
| } | |||
| // Add docs to the collection, if the collection was just created (and not | |||
| // loaded from persistent storage). | |||
| docs := []chromem.Document{} | |||
| var docs []chromem.Document | |||
There was a problem hiding this comment.
For this one, I like to differentiate between cases where it's certain that the slice is going to be filled with elements (e.g. this code example should have 200 elements, otherwise the example is broken), vs cases where it's not certain and where you might later want to check for docs == nil (e.g. in production code with user input).
But that might just be me, and not a big deal, so no blocker
|
thanks for pulling this in warts and all. agree with your comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank goland not me ;)