Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19037 - Link to privilege on table or db without an existing grant #19039

Merged
merged 1 commit into from Apr 27, 2024

Conversation

SachinBahukhandi
Copy link
Contributor

@SachinBahukhandi SachinBahukhandi commented Mar 9, 2024

… edit privilege

Fixes the tableName and DatabaseName not appearing in the query params

Please describe your pull request.

Fixes #19037

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.13%. Comparing base (cfa9bea) to head (c619738).
Report is 81 commits behind head on master.

❗ Current head c619738 differs from pull request most recent head 182f4eb. Consider uploading reports for the commit 182f4eb to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #19039      +/-   ##
============================================
- Coverage     59.17%   59.13%   -0.05%     
- Complexity    15901    15928      +27     
============================================
  Files           670      667       -3     
  Lines         61454    61324     -130     
============================================
- Hits          36368    36264     -104     
+ Misses        25086    25060      -26     
Flag Coverage Δ
dbase-extension 59.13% <ø> (-0.01%) ⬇️
unit-8.1-ubuntu-latest 59.09% <ø> (-0.01%) ⬇️
unit-8.2-ubuntu-latest 59.04% <ø> (-0.08%) ⬇️
unit-8.3-ubuntu-latest 59.06% <ø> (-0.05%) ⬇️
unit-8.4-ubuntu-latest 59.04% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !
Porting this to QA right now

… edit privilege table/db

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>
@williamdes williamdes changed the base branch from master to QA_5_2 April 27, 2024 11:42
@williamdes williamdes self-assigned this Apr 27, 2024
@williamdes williamdes changed the title Fixed fetching the database and table not appearing in query param in… Fix #19037 - Link to privilege on table or db without an existing grant Apr 27, 2024
@williamdes williamdes added this to the 5.2.2 milestone Apr 27, 2024
@williamdes williamdes merged commit 67c42ee into phpmyadmin:QA_5_2 Apr 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.2.1. Can't get into the page with table privileges of a user until I grant it manually
2 participants