Clean-up module ops #276
Merged
Clean-up module ops #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The public interface picotm_is_valid() has no real purpose or use case. This patch removes the interface and its implementation.
The Transactional Memory module only uses pessimistic CC with locking when a memory location is first accessed. The module ops for locking, unlocking and validation are therefore empty. This patch removes the respective functions.
The lock(), unlock(), and validate() operations in |struct file_tx_ops| were not implemented by any file type. This patch removes the respective code.
The functions for locking, unlocking and validation for |struct ofd_tx| state had empty implmentations. This patch removes the respective code.
The lock() and unlock() functions of |struct fildes_tx| have empty implementations. This patch removes the respective functions.
Previous patches merged the update_cc() and clear_cc() for |struct fildes_tx| into finish(). This patch removes the empty functions.
The functionality of update_cc() and clear_cc() have been merged with the finish() call-back function. This patch removes the respective module ops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module ops contain unnecessary function pointers. The structure and it's users should be cleaned up. Additionally, this prepares for 2PC. (#99)