Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player stucks when moving and spamming piccolo #1

Closed
henriiquecampos opened this issue Mar 5, 2018 · 0 comments · Fixed by #4
Closed

Player stucks when moving and spamming piccolo #1

henriiquecampos opened this issue Mar 5, 2018 · 0 comments · Fixed by #4
Labels
bug Something isn't working engineering An engineering solution to implement a design

Comments

@henriiquecampos
Copy link
Owner

No description provided.

@henriiquecampos henriiquecampos added bug Something isn't working engineering An engineering solution to implement a design labels Mar 5, 2018
henriiquecampos added a commit that referenced this issue Mar 5, 2018
@henriiquecampos
Fixed #1
ebce780 
Also fixed a weird behavior when playing a note and then moving, now the character only moves if is not playing and vice versa. This also adds another layer of control for basic_character.gd since now if the character can't move, nothing of the physics_process will happen
@henriiquecampos henriiquecampos mentioned this issue Mar 5, 2018
Merged
henriiquecampos added a commit that referenced this issue Mar 5, 2018
@henriiquecampos
Hotfixes (#4)
ddb0fc1 
* Fixed #1

Also fixed a weird behavior when playing a note and then moving, now the character only moves if is not playing and vice versa. This also adds another layer of control for basic_character.gd since now if the character can't move, nothing of the physics_process will happen

* Fixed #2

When changing to next scene the finished/skip/next button is disabled. Also added a disabled style box to the theme, so when the button is disabled it doesn't seem weird looking.
henriiquecampos added a commit that referenced this issue Mar 5, 2018
@henriiquecampos
Added a "null" set to object and note so they lose reference
732de54 
The major problem of #1 is that after the first time the references are set, they won't reset to null, so the check would only happens successfully once. Now this may definitely fix #1

Also cleared the code removing "can_interact" logic, it isn't needed with the new approach
@henriiquecampos henriiquecampos mentioned this issue Mar 5, 2018
Merged
henriiquecampos added a commit that referenced this issue Mar 5, 2018
@henriiquecampos
Hotfixes (#5)
f5739d4 
* Fixed #1

Also fixed a weird behavior when playing a note and then moving, now the character only moves if is not playing and vice versa. This also adds another layer of control for basic_character.gd since now if the character can't move, nothing of the physics_process will happen

* Fixed #2

When changing to next scene the finished/skip/next button is disabled. Also added a disabled style box to the theme, so when the button is disabled it doesn't seem weird looking.

* Added a "null" set to object and note so they lose reference

The major problem of #1 is that after the first time the references are set, they won't reset to null, so the check would only happens successfully once. Now this may definitely fix #1

Also cleared the code removing "can_interact" logic, it isn't needed with the new approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working engineering An engineering solution to implement a design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hotfixes henriiquecampos/bard-lesson
1 participant
@henriiquecampos