[CoreBundle] Fix down migrations by removing IF EXISTS, not a valid M…

…ySQL 8 statements - related to #15787
pimcore · Aug 21, 2023 · dd81ef4 · dd81ef4
1 parent de564ab
commit dd81ef4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/bundles/CoreBundle/Migrations/Version20220119082511.php b/bundles/CoreBundle/Migrations/Version20220119082511.php
@@ -66,22 +66,22 @@ public function up(Schema $schema): void
 
     public function down(Schema $schema): void
     {
-        if ($schema->getTable('gridconfig_favourites')->hasIndex('grid_config_id')) {
-            $this->addSql('ALTER TABLE `gridconfig_favourites` DROP INDEX IF EXISTS `grid_config_id`;');
-        }
-
         if ($schema->getTable('gridconfig_favourites')->hasForeignKey('fk_gridconfig_favourites_gridconfigs')) {
-            $this->addSql('ALTER TABLE `gridconfig_favourites` DROP FOREIGN KEY IF EXISTS `fk_gridconfig_favourites_gridconfigs`;');
+            $this->addSql('ALTER TABLE `gridconfig_favourites` DROP FOREIGN KEY `fk_gridconfig_favourites_gridconfigs`;');
         }
 
         $this->addSql('ALTER TABLE `gridconfig_favourites` CHANGE `gridConfigId` `gridConfigId` int(11) NULL;');
 
-        if ($schema->getTable('gridconfig_shares')->hasIndex('grid_config_id')) {
-            $this->addSql('ALTER TABLE `gridconfig_shares` DROP INDEX IF EXISTS `grid_config_id`;');
+        if ($schema->getTable('gridconfig_shares')->hasForeignKey('fk_gridconfig_favourites_gridconfigs')) {
+            $this->addSql('ALTER TABLE `gridconfig_shares` DROP FOREIGN KEY `fk_gridconfig_shares_gridconfigs`;');
         }
 
-        if ($schema->getTable('gridconfig_shares')->hasForeignKey('fk_gridconfig_favourites_gridconfigs')) {
-            $this->addSql('ALTER TABLE `gridconfig_shares` DROP FOREIGN KEY IF EXISTS `fk_gridconfig_shares_gridconfigs`;');
+        if ($schema->getTable('gridconfig_favourites')->hasIndex('grid_config_id')) {
+            $this->addSql('ALTER TABLE `gridconfig_favourites` DROP INDEX `grid_config_id`;');
+        }
+
+        if ($schema->getTable('gridconfig_shares')->hasIndex('grid_config_id')) {
+            $this->addSql('ALTER TABLE `gridconfig_shares` DROP INDEX `grid_config_id`;');
         }
     }
 }
diff --git a/bundles/CoreBundle/Migrations/Version20220120121803.php b/bundles/CoreBundle/Migrations/Version20220120121803.php
@@ -87,12 +87,12 @@ public function down(Schema $schema): void
     {
         foreach (['documents_hardlink', 'documents_link', 'documents_page', 'documents_snippet', 'documents_printpage', 'documents_email', 'email_log', 'documents_newsletter', 'documents_editables', 'documents_translations'] as $table) {
             if ($schema->getTable($table)->hasForeignKey('fk_'.$table.'_documents')) {
-                $this->addSql('ALTER TABLE `'.$table.'` DROP FOREIGN KEY IF EXISTS `fk_'.$table.'_documents`;');
+                $this->addSql('ALTER TABLE `'.$table.'` DROP FOREIGN KEY `fk_'.$table.'_documents`;');
             }
         }
 
         if ($schema->getTable('sites')->hasForeignKey('fk_sites_documents')) {
-            $this->addSql('ALTER TABLE `sites` DROP FOREIGN KEY IF EXISTS `fk_sites_documents`;');
+            $this->addSql('ALTER TABLE `sites` DROP FOREIGN KEY `fk_sites_documents`;');
         }
     }
 }
diff --git a/bundles/CoreBundle/Migrations/Version20220120162621.php b/bundles/CoreBundle/Migrations/Version20220120162621.php
@@ -121,11 +121,11 @@ public function down(Schema $schema): void
     {
         foreach (['asset', 'document', 'object'] as $elementType) {
             if ($schema->getTable('users_workspaces_'.$elementType)->hasForeignKey('fk_users_workspaces_'.$elementType.'_'.$elementType.'s')) {
-                $this->addSql('ALTER TABLE `users_workspaces_'.$elementType.'` DROP FOREIGN KEY IF EXISTS `fk_users_workspaces_'.$elementType.'_'.$elementType.'s`');
+                $this->addSql('ALTER TABLE `users_workspaces_'.$elementType.'` DROP FOREIGN KEY `fk_users_workspaces_'.$elementType.'_'.$elementType.'s`');
             }
 
             if ($schema->getTable('users_workspaces_'.$elementType)->hasForeignKey('fk_users_workspaces_'.$elementType.'_users')) {
-                $this->addSql('ALTER TABLE `users_workspaces_'.$elementType.'` DROP FOREIGN KEY IF EXISTS `fk_users_workspaces_'.$elementType.'_users`');
+                $this->addSql('ALTER TABLE `users_workspaces_'.$elementType.'` DROP FOREIGN KEY `fk_users_workspaces_'.$elementType.'_users`');
             }
 
             $this->addSql('ALTER TABLE `users_workspaces_'.$elementType.'` CHANGE `userId` `userId` int(11) NOT NULL DEFAULT \'0\'');