New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix thumbnail generation if asset or config is null #17039

Merged

mattamon merged 1 commit into 11.2 from fix-thumbnail-generation-on-empty-asset

May 13, 2024

Contributor

mattamon commented May 13, 2024

Changes in this pull request

Error images do not need an asset or config. Move checks to certain conditions


          Fix thumbnail generation if asset or config is null

15538bf

mattamon added the Bug label

mattamon added this to the 11.2.4 milestone

github-actions bot commented May 13, 2024

Review Checklist

Target branch (11.2 for bug fixes, others 11.x)
Tests (if it's testable code, there should be a test for it - get help)
Docs (every functionality needs to be documented, see here)
Migration incl. install.sql (e.g. if the database schema changes, ...)
Upgrade notes (deprecations, important information, migration hints, ...)
Label
Milestone

mattamon mentioned this pull request

[Bug] Fix thumbnail generation if asset or config is null #17038

Closed

sonarcloud bot commented May 13, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

mattamon merged commit 38af70b into 11.2

18 checks passed

mattamon deleted the fix-thumbnail-generation-on-empty-asset branch

May 13, 2024 13:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment