Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix thumbnail generation if asset or config is null #17038

Closed
wants to merge 3 commits into from
Closed

[Bug] Fix thumbnail generation if asset or config is null #17038

wants to merge 3 commits into from

Conversation

mattamon
Copy link
Contributor

Changes in this pull request

Error images do not need an asset or config. Move checks to certain conditions

@mattamon mattamon added the Bug label May 13, 2024
@mattamon mattamon added this to the 11.2.4 milestone May 13, 2024
@github-actions GitHub Actions
Copy link

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@blankse
Copy link
Contributor

blankse commented May 13, 2024

Target branch should be 11.2

@mattamon
Copy link
Contributor Author

Target branch should be 11.2

I know, but I want to test something first. Changes will be cherry picked anyways

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mattamon mattamon removed this from the 11.2.4 milestone May 13, 2024
@mattamon mattamon marked this pull request as draft May 13, 2024 11:47
@mattamon
Copy link
Contributor Author

Closed in favor of #17039

@mattamon mattamon closed this May 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
@mattamon mattamon deleted the fix-empty-asset branch May 13, 2024 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blankse blankse blankse left review comments

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattamon @blankse