Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Grid filter improvement: link (href/mutlihref), images, and empty values. #699

Closed
Yivan opened this issue Jun 24, 2016 · 6 comments

Comments

@Yivan
Copy link
Contributor

Yivan commented Jun 24, 2016

On the object grid, it is possible to filter "path" column. But for instance "href"/"multihref"(asset/objectdocument link) type column can not be filtered.

By the way adding the possibility to filter "empty" values would help administrator to find for instance object with empty href/multihref link. Or object where image (image type field) is not filled. I know it could be done by making a custom report to find empty value, but is is more convenient for enduser to use directly the grid when he work on his dataset.

@Yivan Yivan changed the title Grid filter improvement: link (href/mutlihref), images, and empty values. [Improvement] Grid filter improvement: link (href/mutlihref), images, and empty values. Jun 18, 2019
@kubaplas
Copy link
Contributor

@brusch do you have any plans regarding this issue?

@fashxp
Copy link
Member

fashxp commented May 22, 2020

not on our prio list yet, we are happy to merge PRs for that though (maybe with a short discussion about the planned solution before implementing it completely)

@greefhorst
Copy link

@fashxp I've been working on the issue for some time, but ran into the same issues as @BlackbitNeueMedien in #3031: how to fill the filters and trigger an ajax call? In the meantime, I was able to do build a well working list filter, but this might result in a very long options list (although 200 options is already accepted for Country select fields). How do you feel about this? Or do you have any suggestions on how linking the values from a popup to the filter?
image
(I used the object key in the example, but this might also be another column (path?), or maybe using the PathFormatter class configured for the field.

@fashxp
Copy link
Member

fashxp commented Oct 6, 2020

@greefhorst thank you for your input.

How do you feel about this?
looks nice, but I'm not sure if this really scales and is robust enough. what, if you have thousands of objects of the liked class (or no class limit in the class definition at all, so all data objects in the system are valid options).

Or do you have any suggestions on how linking the values from a popup to the filter?
sorry, not really.
maybe not implement it as grid filter from ext but as some custom filter similar to the sql filter?

@kubaplas
Copy link
Contributor

@greefhorst Did you continue working on this feature? If you dropped it, maybe you can share the code? I can try to finish the job ;)

@brusch brusch removed the Proposal label Mar 2, 2022
@brusch
Copy link
Member

brusch commented Mar 8, 2022

Fixed by #10022 🥳

@brusch brusch closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants