[Object grid] Quantity value filter #5211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tity-value-filter # Conflicts: # bundles/AdminBundle/Resources/public/js/pimcore/object/tags/quantityValue.js
|
$value in not an array if you open the filter but leave the unit combo empty. This will result in an error.
Apart from that, awesome stuff 👍 |
|
Thanks @weisswurstkanone - nice to hear that all those evenings were worth it. Fixed the mentioned bug. Looking forward to your review. When this PR is merged I will start implementing the even more important relation filter (#699)... |
|
Excellent! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the grid column filter for quantity value fields. It supports selecting a unit and also converts the value to be compared to compatible units, e.g. when you filter for "< 10 cm" it also finds objects which have "50 mm" in the quantity value field (given those units have been set to be convertable).