[Task] Optimized get by UUID #14633
Merged
[Task] Optimized get by UUID #14633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
NiklasBr
reviewed
Mar 15, 2023
models/Tool/UUID/Dao.php
Outdated
| @@ -80,7 +80,7 @@ public function delete() | |||
| */ | |||
| public function getByUuid($uuid) | |||
| { | |||
| $data = $this->db->fetchAssociative('SELECT * FROM ' . self::TABLE_NAME ." where uuid='" . $uuid . "'"); | |||
| $data = $this->db->fetchAssociative('SELECT * FROM ' . self::TABLE_NAME . ' where uuid= ?', [$uuid]); | |||
There was a problem hiding this comment.
I suggest supplying the third param with a type instead [Types::STRING] if you must:
https://www.doctrine-project.org/projects/doctrine-dbal/en/2.13/reference/security.html#security
Besides binding parameters you can also pass the type of the variable. This allows Doctrine or the underlying vendor to not only escape but also cast the value to the correct type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.