Areablock: Accept array for setDataFromResource() #16773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
mattamon
reviewed
Mar 29, 2024
| $unserializedData = Tool\Serialize::unserialize($data); | ||
| if (is_string($data)) { | ||
| $unserializedData = Tool\Serialize::unserialize($data); | ||
| } else { |
There was a problem hiding this comment.
We could remove the else and just set $unserializedData = $data as default no?
There was a problem hiding this comment.
@mattamon This was possible, but I made it more type safe. It was possible to put a wrong type and nothing happens. I think it should be throw a InvalidArgumentException() like in the renderlet editable.
blankse
force-pushed
the
areablock_respect_array_data
branch
from
df84246
to
ce041a5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/orgs/pimcore/discussions/16672
See #16701