Remove sites dependency #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sites is no longer enabled by default in Django 1.7.x, see: django/django@23fc91a6
|
#148 may be preferred over my version, but either way I think it would be best to not require Sites for using django-user-accounts. Thanks! |
Use form prefix and identifier_field when dispatching signals
changed 'for' to 'from'
Sphinx config typo
Added `user` and `inviter` to admin `raw_id_fields`
Docs: use full code-blocks for python highlighting
|
Changes Unknown when pulling 1e7a995 on PersonalGenomesOrg:remove-sites-dependency into * on pinax:master*. |
1 similar comment
|
Changes Unknown when pulling 1e7a995 on PersonalGenomesOrg:remove-sites-dependency into * on pinax:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sites is no longer enabled by default since Django 1.6.x, see: django/django@23fc91a6
Sites was only necessary for one remaining location in the code (email confirmation upon email change in
SettingsView), and this code now usesget_current_siteto remove that dependency (as is done for the email confirmation done bySignUpView).I think this change means that the
EmailConfirmation.sendmethod will always receive asitekeyword argument (so code could be rewritten to depend on receiving asitekwarg). I haven't changed the code more extensively because it's possible some users overriding aspects of this package won't be passing asiteargument, and you may want to continue supporting that.