Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conn: fix inaccurate region count #127

Merged
merged 3 commits into from Dec 24, 2019

Conversation

overvenus
Copy link
Member

Encode keys into memcomparable-format before calling stats/region.

Fix #125

Signed-off-by: Neil Shen <overvenus@gmail.com>
@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #127   +/-   ##
======================================
  Coverage    73.7%   73.7%           
======================================
  Files          33      33           
  Lines        3195    3195           
======================================
  Hits         2355    2355           
  Misses        562     562           
  Partials      278     278

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bdb5b7...bcae745. Read the comment docs.

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but could we create a test case for getRegionCountWith?

@kennytm kennytm added the status/LGT1 LGTM1 label Dec 23, 2019
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus merged commit 56e206e into pingcap:master Dec 24, 2019
@overvenus overvenus deleted the fix-inaccurate-backup-progress branch December 24, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backup progress is inaccurate
3 participants