-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv config file: fix a typo #4906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-srebot
added
the
first-time-contributor
Indicates that the PR was contributed by an external member and is a first-time contributor.
label
Nov 13, 2020
TomShawn
added
needs-cherry-pick-3.1
size/small
Changes of a small size.
translation/no-need
No need to translate this PR.
type/bug-fix
Fixes typos, wrong format, or other wrong or inaccurate document content.
labels
Nov 16, 2020
TomShawn
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zgcbj Thanks!
ti-srebot
pushed a commit
to ti-srebot/docs-cn
that referenced
this pull request
Nov 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
cherry pick to release-3.0 in PR #4907 |
ti-srebot
pushed a commit
to ti-srebot/docs-cn
that referenced
this pull request
Nov 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
cherry pick to release-3.1 in PR #4908 |
ti-srebot
pushed a commit
to ti-srebot/docs-cn
that referenced
this pull request
Nov 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
cherry pick to release-4.0 in PR #4909 |
TomShawn
added a commit
that referenced
this pull request
Nov 16, 2020
* cherry pick #4906 to release-3.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Apply suggestions from code review Co-authored-by: zgcbj <1614439+zgcbj@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
pushed a commit
that referenced
this pull request
Nov 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: zgcbj <1614439+zgcbj@users.noreply.github.com>
TomShawn
added a commit
that referenced
this pull request
Nov 16, 2020
* cherry pick #4906 to release-3.1 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Apply suggestions from code review * trigger CI * Update tikv-configuration-file.md Co-authored-by: zgcbj <1614439+zgcbj@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
first-time-contributor
Indicates that the PR was contributed by an external member and is a first-time contributor.
size/small
Changes of a small size.
status/LGT1
Indicates that a PR has LGTM 1.
translation/no-need
No need to translate this PR.
type/bug-fix
Fixes typos, wrong format, or other wrong or inaccurate document content.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Fix a typo in tikv-configuration-file.md.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?