Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc add output old value config #17366

Merged
merged 2 commits into from May 13, 2024
Merged

ticdc add output old value config #17366

merged 2 commits into from May 13, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Apr 26, 2024 •
edited by sdojjy

What is changed, added or deleted? (Required)

Add sink.open.output-old-value and sink.debezium.output-old-value to control whether to output the value before the row data changes.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. v8.1 This PR/issue applies to TiDB v8.1. labels Apr 26, 2024
@Oreoxmt Oreoxmt self-assigned this Apr 26, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Apr 26, 2024

/cc @sdojjy

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2024
@ti-chi-bot ti-chi-bot bot requested a review from sdojjy April 26, 2024 02:33
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2024
qiancai
qiancai approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

ticdc/ticdc-open-api-v2.md Outdated Show resolved Hide resolved
ticdc/ticdc-open-api-v2.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-29 08:01:49.669415942 +0000 UTC m=+257863.426551518: ☑️ agreed by qiancai.

@Oreoxmt @qiancai
Apply suggestions from code review
24b3e71 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 6, 2024

@sdojjy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt added the lgtm label May 13, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented May 13, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 13, 2024
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4d68bac into pingcap:master May 13, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17473.

@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2024
Open
16 tasks
dveeden pushed a commit to dveeden/docs that referenced this pull request May 15, 2024
@Oreoxmt @dveeden
ticdc add output old value config (pingcap#17366)
729dc2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdojjy sdojjy sdojjy approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-1-more-lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.1 This PR/issue applies to TiDB v8.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Oreoxmt @ti-chi-bot @sdojjy @qiancai