Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: add ddl-related error code and name #630

Merged
merged 5 commits into from Nov 12, 2019

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Nov 10, 2019

What problem does this PR solve?

Some errors in TiDB do not have an error code. Add parts of them.

Related TiDB PR: pingcap/tidb#13329

Side effects

  • Breaking backward compatibility

@bb7133 bb7133 requested a review from a team November 10, 2019 11:11
@ghost ghost requested review from tangenta and removed request for a team November 10, 2019 11:11
@codecov
Copy link

codecov bot commented Nov 10, 2019

Codecov Report

Merging #630 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #630   +/-   ##
=======================================
  Coverage   79.97%   79.97%           
=======================================
  Files          32       32           
  Lines       12666    12666           
=======================================
  Hits        10130    10130           
  Misses       1934     1934           
  Partials      602      602

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3789d9...bb2a4cb. Read the comment docs.

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/LGT1 LGT1 label Nov 10, 2019
@bb7133 bb7133 added the type/enhancement New feature or request label Nov 10, 2019
@bb7133
Copy link
Member Author

bb7133 commented Nov 10, 2019

PTAL @jackysp

mysql/errname.go Outdated Show resolved Hide resolved
mysql/errname.go Outdated Show resolved Hide resolved
mysql/errname.go Outdated Show resolved Hide resolved
mysql/errname.go Outdated Show resolved Hide resolved
mysql/errname.go Show resolved Hide resolved
mysql/errname.go Outdated Show resolved Hide resolved
@bb7133 bb7133 force-pushed the refine_ddl_errcode branch 2 times, most recently from cfda927 to 7e37f16 Compare November 11, 2019 18:32
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Nov 12, 2019
@bb7133 bb7133 merged commit 3b43b46 into pingcap:master Nov 12, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 LGT2 type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants