Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql: update some TiDB customized error code #671

Merged
merged 3 commits into from Dec 10, 2019
Merged

mysql: update some TiDB customized error code #671

merged 3 commits into from Dec 10, 2019

Conversation

tiancaiamao
Copy link
Collaborator

What problem does this PR solve?

Define the error code for pingcap/tidb#14002

What is changed and how it works?

Update some TiDB customized error code

Check List

Tests

  • No code

Code changes

  • Has exported variable/fields change

@tiancaiamao tiancaiamao requested a review from a team December 10, 2019 03:34
@ghost ghost requested review from tangenta and removed request for a team December 10, 2019 03:35
@tiancaiamao tiancaiamao added the type/enhancement New feature or request label Dec 10, 2019
@codecov
Copy link

codecov bot commented Dec 10, 2019 •
edited

Codecov Report

Merging #671 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
- Coverage    80.1%   80.04%   -0.07%     
==========================================
  Files          33       32       -1     
  Lines       12958    12887      -71     
==========================================
- Hits        10380    10315      -65     
+ Misses       1961     1958       -3     
+ Partials      617      614       -3
Impacted Files Coverage Δ
parser.go 93.01% <0%> (-0.05%) ⬇️
ast/util.go 75% <0%> (ø) ⬆️
misc.go 96.49% <0%> (ø) ⬆️
ast/advisor.go
ast/ddl.go 79.78% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753e13b...84e1522. Read the comment docs.

kennytm
kennytm reviewed Dec 10, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Dec 10, 2019
tangenta
tangenta approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Dec 10, 2019
@tangenta tangenta merged commit bdf23a7 into pingcap:master Dec 10, 2019
@tiancaiamao tiancaiamao deleted the update-errorcode branch December 10, 2019 06:11
tiancaiamao added a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@tiancaiamao @tangenta
mysql: update some TiDB customized error code (pingcap#671)
f8fd4b8
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@tiancaiamao @tangenta
mysql: update some TiDB customized error code (pingcap#671)
4b0a400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2 type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiancaiamao @kennytm @tangenta