Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Decouple Checkpoint type from dest-type (#786) #790

Merged
merged 2 commits into from Nov 5, 2019
Merged

*: Decouple Checkpoint type from dest-type (#786) #790

merged 2 commits into from Nov 5, 2019

Commits on Nov 4, 2019

  1. *: Decouple Checkpoint type from dest-type 

    after this pr:
we have this checkpoint type: mysql/tidb, file, flash
defalut using checkpoint type accroding to dest-type like before
mysql/tidb -> mysql/tidb (the same downstream)
flash -> flash
kafka/file -> file

and we can configure the checkpoint type despite what the dest-type is;
currently only can configure the checkpoint type to be mysql/tidb
    @july2993 @sre-bot
    july2993 authored and sre-bot committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    3533d05 View commit details
    Browse the repository at this point in the history

  2. Address comment

    @july2993 @sre-bot
    july2993 authored and sre-bot committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    c246e79 View commit details
    Browse the repository at this point in the history