New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add startUpScriptVersion for pd spec #4379
Conversation
support add startUpScriptVersion as v1 to use dig to wait dns can be resolved: ... pd: startUpScriptVersion: "v1" ...
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4379 +/- ##
==========================================
+ Coverage 62.63% 71.72% +9.08%
==========================================
Files 184 188 +4
Lines 19573 21960 +2387
==========================================
+ Hits 12260 15750 +3490
+ Misses 6167 5080 -1087
+ Partials 1146 1130 -16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3ffd0bf
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-1.2 in PR #4411 |
What problem does this PR solve?
for version >= v.5.0.5, the nslookup version is changed in the image.
if nameserver in
/etc/resolv.conf
contains not only coredns cluster ip, PD pod will fail to start since the startup script use nslookup and the behavior of nslookup is different from general resolver.ref: https://serverfault.com/a/398854
coredns/coredns#3835 (comment)
https://github.com/isc-projects/bind9/blob/808d0b07b00244de735be68ce85b2652e4e0efec/bin/dig/dighost.c#L4128-L4162
we will hit the
check_ra&&。。
condition here, and nslookup will try the next nameserver, and the next nameserver will return NXDOMAIN(since it is not the coredns)What is changed and how does it work?
support add startUpScriptVersion as v1 to use dig to wait dns can be
resolved:
...
pd:
startUpScriptVersion: "v1"
...
Code changes
Tests
startUpScriptVersion
as v1apply some invalid value
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.