Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate system variables tidb_mem_quota_XXX #12346

Closed
SunRunAway opened this issue Sep 24, 2019 · 0 comments · Fixed by #15084
Closed

Deprecate system variables tidb_mem_quota_XXX #12346

SunRunAway opened this issue Sep 24, 2019 · 0 comments · Fixed by #15084
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement
Projects
SIG Runtime Kanban
Milestone
v4.0.0-beta.1

Comments

@SunRunAway
Copy link
Contributor

SunRunAway commented Sep 24, 2019 •
edited

Feature Request

Is your feature request related to a problem? Please describe:

After #12067, we do not need these system variables anymore. Deprecate them in 4.0 release.

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:
@SunRunAway SunRunAway changed the title Deprecate tidb_mem_quota_hashjoin/tidb_mem_quota_mergejoin etc... Deprecate system variables tidb_mem_quota_XXX Sep 24, 2019
@SunRunAway SunRunAway mentioned this issue Sep 24, 2019
Merged
@SunRunAway SunRunAway added priority/release-blocker This PR blocks a release. Please review it ASAP. type/4.0 cherry-pick labels Sep 24, 2019
@SunRunAway SunRunAway added this to the v4.0.0 milestone Sep 24, 2019
@SunRunAway SunRunAway removed type/4.0 cherry-pick priority/release-blocker This PR blocks a release. Please review it ASAP. labels Sep 25, 2019
@SunRunAway SunRunAway added difficulty/easy good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 2, 2020
@SunRunAway SunRunAway mentioned this issue Mar 3, 2020
Merged
@zz-jason zz-jason added this to Need Triage in SIG Runtime Kanban via automation Mar 10, 2020
SIG Runtime Kanban automation moved this from Need Triage to Done Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement
Projects
No open projects
SIG Runtime Kanban
  
Done (Historical)
Milestone
v4.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

*: deprecate system variables tidb_mem_quota_XXX SunRunAway/tidb
1 participant
@SunRunAway