Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: fix uint64 overflow bug in ConvertJSONToFloat (#11355) #11433

Merged
merged 4 commits into from Jul 25, 2019
Merged

types: fix uint64 overflow bug in ConvertJSONToFloat (#11355) #11433

merged 4 commits into from Jul 25, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 25, 2019

cherry-pick #11355 to release-3.0

@H-ZeX
fix bug of convert json to float
aa547e2 
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
@H-ZeX
fix bug of convert json to float
79f59db 
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
@H-ZeX
expression: add a integration
1a0b657 
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 25, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Jul 25, 2019
Merged
lonng
lonng reviewed Jul 25, 2019
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lzmhhh123
lzmhhh123 approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Jul 25, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 25, 2019

/run-all-tests

@sre-bot sre-bot merged commit fdaee60 into pingcap:release-3.0 Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonng lonng lonng left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sre-bot @lonng @lzmhhh123 @H-ZeX