Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: explain a physicalPlan with IndexMerge in "dot" format #12248

Merged
merged 2 commits into from Sep 18, 2019
Merged

planner: explain a physicalPlan with IndexMerge in "dot" format #12248

merged 2 commits into from Sep 18, 2019

Conversation

hailanwhu
Copy link
Contributor

What problem does this PR solve?

After a physical plan with IndexMergePath generated, it should be explained.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes
planner/core/common_plan.go prepareTaskDot()

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 18, 2019
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #12248 into master will decrease coverage by 0.0238%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             master     #12248        +/-   ##
================================================
- Coverage   81.1266%   81.1027%   -0.0239%     
================================================
  Files           454        454                
  Lines         98811      98628       -183     
================================================
- Hits          80162      79990       -172     
+ Misses        12881      12874         -7     
+ Partials       5768       5764         -4

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added this to In Progress in IndexMerge access method for DNF filters via automation Sep 18, 2019
@zz-jason zz-jason added sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2019
@zz-jason zz-jason changed the title explain a physicalPlan with IndexMerge in "dot" format planner: explain a physicalPlan with IndexMerge in "dot" format Sep 18, 2019
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit da6a7bd into pingcap:master Sep 18, 2019
IndexMerge access method for DNF filters automation moved this from In Progress to Done Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants