executor: make IndexHashJoin support keeping the outer order #12349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
XuHuaiyu
force-pushed
the
indexhashjoin_order
branch
from
6346ffe
to
b1d6d7e
Compare
Codecov Report
@@ Coverage Diff @@
## master #12349 +/- ##
===========================================
Coverage ? 80.0544%
===========================================
Files ? 462
Lines ? 105753
Branches ? 0
===========================================
Hits ? 84660
Misses ? 14780
Partials ? 6313 |
|
/rebuild |
XuHuaiyu
force-pushed
the
indexhashjoin_order
branch
from
9ff5f38
to
4c6a7c6
Compare
|
/run-all-tests |
XuHuaiyu
requested review from
SunRunAway,
wshwsh12,
Reminiscent,
zz-jason,
fzhedu and
lzmhhh123
|
PTAL @SunRunAway @qw4990 |
1 similar comment
|
PTAL @SunRunAway @qw4990 |
|
/run-all-tests |
qw4990
reviewed
Oct 17, 2019
executor/index_lookup_hash_join.go
Outdated
| @@ -482,3 +614,77 @@ func (iw *indexHashJoinInnerWorker) joinMatchedInnerRow2Chunk(ctx context.Contex | |||
| } | |||
| return true, joinResult | |||
| } | |||
|
|
|||
| func (iw *indexHashJoinInnerWorker) collectMatchedInnerPtrs4OuterRows(ctx context.Context, innerRow chunk.Row, innerRowPtr chunk.RowPtr, task *indexHashJoinTask, | |||
| joinResult *indexHashJoinResult, h hash.Hash64, buf []byte) error { | |||
There was a problem hiding this comment.
joinResult is not used in this function.
SunRunAway
reviewed
Oct 17, 2019
|
/run-all-tests |
SunRunAway
approved these changes
Oct 17, 2019
SunRunAway
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 12773 |
|
/run-all-tests |
|
@XuHuaiyu merge failed. |
|
/run-integration-common-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
For testing the correctness, I change the execution logic that IndexJoin and IndexMergeJoin both execute IndexHashJoin actually.
What problem does this PR solve?
Make the IndexHashJoin support keeping the result as the outer order.
What is changed and how it works?
Add a keepOuterOrder attribute for IndexHashJoin, outerWorker, and IndexHashJoinTask, when keepOuterOrder is true, a task will be sent to the channels maintained in the main thread and inner workers separately. And the result will be fetched from task.resultCh one by one.
Check List
Tests
Exists tests.
Code changes
Side effects
N/A
Related changes
N/A
Release note
N/A