Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: retrieve optimizer hint scope change #12382

Merged
merged 7 commits into from Oct 8, 2019

Conversation

foreyes
Copy link
Contributor

@foreyes foreyes commented Sep 25, 2019

What problem does this PR solve?

Retrieve change from #11740

What is changed and how it works?

Retrieve change from #11740

Check List

Tests

  • Unit test

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

  • None

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #12382 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12382   +/-   ##
===========================================
  Coverage   79.8706%   79.8706%           
===========================================
  Files           460        460           
  Lines        102517     102517           
===========================================
  Hits          81881      81881           
  Misses        14691      14691           
  Partials       5945       5945

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests?

planner/core/logical_plan_builder.go Outdated Show resolved Hide resolved
@foreyes
Copy link
Contributor Author

foreyes commented Sep 25, 2019

/run-unit-test

@foreyes
Copy link
Contributor Author

foreyes commented Sep 26, 2019

/run-all-tests

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2019
@foreyes
Copy link
Contributor Author

foreyes commented Sep 29, 2019

PTAL. @lzmhhh123

@foreyes foreyes force-pushed the dev/revert_hint_scope_again branch from 050dc51 to 3869a47 Compare October 8, 2019 01:00
@foreyes
Copy link
Contributor Author

foreyes commented Oct 8, 2019

coding mistake fixed... @lzmhhh123

Copy link
Member

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 8, 2019

Your auto merge job has been accepted, waiting for 12518

@sre-bot
Copy link
Contributor

sre-bot commented Oct 8, 2019

/run-all-tests

@sre-bot sre-bot merged commit fc577e7 into pingcap:master Oct 8, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 8, 2019

cherry pick to release-3.1 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants