Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema/slow_query: add more field in slow_query table #13007

Merged
merged 9 commits into from Nov 1, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Oct 29, 2019

What problem does this PR solve?

  • add more field in slow_query table.
    • Prewrite_time
    • Commit_time
    • Get_commit_ts_time
    • Commit_backoff_time
    • Backoff_types
    • Resolve_lock_time
    • Local_latch_wait_time
    • Write_keys
    • Write_size
    • Prewrite_region
    • Txn_retry

What is changed and how it works?

  • infoschema/slow_query

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Add more fields in slow_query table to improve the usability of slow query:
    • A

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #13007 into master will increase coverage by 0.3618%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #13007        +/-   ##
================================================
+ Coverage   80.0448%   80.4066%   +0.3618%     
================================================
  Files           468        468                
  Lines        109811     111946      +2135     
================================================
+ Hits          87898      90012      +2114     
- Misses        15164      15209        +45     
+ Partials       6749       6725        -24

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 30, 2019
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bb7133
bb7133 previously approved these changes Nov 1, 2019
@bb7133 bb7133 added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 1, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 1, 2019

@crazycs520 merge failed.

@crazycs520
Copy link
Contributor Author

/run-integration-common-test

util/execdetails/execdetails.go Outdated Show resolved Hide resolved
util/execdetails/execdetails.go Outdated Show resolved Hide resolved
@AilinKid AilinKid added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2019
@AilinKid
Copy link
Contributor

AilinKid commented Nov 1, 2019

/run-uint-test

Co-Authored-By: Arenatlx <ailinsilence4@gmail.com>
@bb7133
Copy link
Member

bb7133 commented Nov 1, 2019

/run-unit-test

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid AilinKid added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Nov 1, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests

@bb7133
Copy link
Member

bb7133 commented Nov 1, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 1, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 1, 2019

cherry pick to release-3.0 in PR #13072

@sre-bot
Copy link
Contributor

sre-bot commented Nov 1, 2019

cherry pick to release-3.1 failed

@sre-bot
Copy link
Contributor

sre-bot commented Nov 1, 2019

cherry pick to release-2.1 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants