Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindinfo: correctly handle quotes for bindings sql (#13115) #13117

Merged
merged 2 commits into from Nov 5, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Nov 4, 2019

Cherry pick #13115
Conflcts: bindinfo/handle.go, bindinfo/bind_test.go

Copy link
Member

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eurekaka eurekaka added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 5, 2019

Your auto merge job has been accepted, waiting for 13118

@sre-bot
Copy link
Contributor

sre-bot commented Nov 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit c99e6b2 into pingcap:release-3.0 Nov 5, 2019
@alivxxx alivxxx deleted the quotes-3.0 branch November 13, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants