planner: support hint for IndexHashJoin and IndexMergeJoin #13238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
force-pushed
the
indexjoin_hint
branch
from
00bc548
to
efa1b90
Compare
Codecov Report
@@ Coverage Diff @@
## master #13238 +/- ##
===========================================
Coverage 80.5742% 80.5742%
===========================================
Files 471 471
Lines 115419 115419
===========================================
Hits 92998 92998
Misses 15352 15352
Partials 7069 7069 |
alivxxx
reviewed
Nov 11, 2019
lzmhhh123
reviewed
Nov 11, 2019
XuHuaiyu
force-pushed
the
indexjoin_hint
branch
from
b458d33
to
2ae0b6a
Compare
|
/run-all-tests |
alivxxx
reviewed
Nov 12, 2019
lzmhhh123
reviewed
Nov 13, 2019
| if rightJoins != nil && (rightOuter && !leftOuter || rhsCardinality < lhsCardinality) { | ||
| return rightJoins, rightOuter | ||
| switch { | ||
| case p.JoinType == InnerJoin && p.Children()[0].statsInfo().Count() < p.Children()[1].statsInfo().Count(): |
There was a problem hiding this comment.
Well, I don't think it's always a better choice for the situation to force left outers. What about remove the second condition?
There was a problem hiding this comment.
Then we can get both sides inner join.
There was a problem hiding this comment.
It'll affect many plans, using an individual PR is better. This issue traces it.
lzmhhh123
reviewed
Nov 13, 2019
XuHuaiyu
force-pushed
the
indexjoin_hint
branch
from
30af04b
to
8a800df
Compare
lzmhhh123
approved these changes
Nov 13, 2019
lzmhhh123
added
the
status/can-merge
|
/run-all-tests |
|
@XuHuaiyu merge failed. |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
1. fix issue #123092. support hint for IndexHashJoin and IndexMergeJoin
What is changed and how it works?
Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes
N/A
Release note
N/A