Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privilege: fix REVOKE privilege check incompatibility with MySQL (#13014) #13307

Closed
wants to merge 5 commits into from

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Nov 9, 2019

cherry-pick #13014 to release-3.1


What problem does this PR solve?

Originally, execute REVOKE query demand user have SuperPriv, which is incompatibility with MySQL in such case.

create user u1;
create user u2;
grant select on *.* to u1 with grant option.
grant select on *.* to u2;
// login as u1
revoke select on *.* from u2;

TiDB will return error, MySQL is ok.

What is changed and how it works?

change privilege check for REVOKE like GRANT. If a user has grant option on some object like table or db, he can revoke privilege on these object from other users.

Check List

Tests

  • Unit test

Code changes

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

  • fix privilege check for REVOKE

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 9, 2019

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 11, 2019

Your auto merge job has been accepted, waiting for 13306

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 11, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 11, 2019

@sre-bot merge failed.

@coocood coocood closed this Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/privilege status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix This PR fixes a bug. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants