infoschema: add TIDB_ROW_ID_SHARDING_INFO for table table.
#13418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb7133
commented
Nov 13, 2019
| // - "SHARD_BITS={bit_number}": for tables that with SHARD_ROW_ID_BITS. | ||
| // The returned nil indicates that sharding information is not suitable for the table(for example, when the table is a View). | ||
| // This function is exported for unit test. | ||
| func GetShardingInfo(dbInfo *model.DBInfo, tableInfo *model.TableInfo) interface{} { |
There was a problem hiding this comment.
@djshow832 I suggest changing the return type to string and returning "NIL" if it's not suitable.
Why this is better?
I still prefer to nil because it will be converted as NULL of MySQL, but string "nil" will not.
|
PTAL @djshow832 @zimulala @lonng |
Codecov Report
@@ Coverage Diff @@
## master #13418 +/- ##
=========================================
Coverage 80.483% 80.483%
=========================================
Files 472 472
Lines 115920 115920
=========================================
Hits 93296 93296
Misses 15440 15440
Partials 7184 7184 |
bb7133
force-pushed
the
bb7133/add_shard_info
branch
from
92ed26d
to
853850b
Compare
lonng
reviewed
Nov 13, 2019
lonng
reviewed
Nov 13, 2019
|
@bb7133 please add some proper labels for this PR. |
Done, thanks for reminding |
bb7133
added
status/LGT1
crazycs520
added
status/LGT3
bb7133
added
status/LGT2
|
/run-all-tests |
bb7133
added
the
status/can-merge
|
/run-all-tests |
|
@bb7133 merge failed. |
|
/run-all-tests |
|
/run-unit-test |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR adds an extra column
TIDB_ROW_ID_SHARDING_INFOtoinformation_schema.tablestable, which gives a brief description of the sharding information of the table:The description may be:
"NOT_SHARDED"for tables that SHARD_ROW_ID_BITS is not specified."NOT_SHARDED(PK_IS_HANDLE)"for tables that primary key is part of row id(akaPK_IS_HANDLE)."SHARD_BITS={bit_number}": for tables that are defined with SHARD_ROW_ID_BITS.nil: for tables that are not suitable(views, system tables).What is changed and how it works?
A
GetShardingInfois added to retrieve such information.Check List
Tests
Code changes
Side effects
Related changes