Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: print the number of cop-tasks in results of explain analyze #13686

Merged
merged 3 commits into from Nov 23, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 22, 2019

What problem does this PR solve?

Print the number of cop-tasks in results of explain analyze.

What is changed and how it works?

Add the information about the number of cop-tasks when rendering the explain analyze result.

@qw4990 qw4990 added the sig/execution SIG execution label Nov 22, 2019
@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #13686 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13686   +/-   ##
===========================================
  Coverage   79.9357%   79.9357%           
===========================================
  Files           474        474           
  Lines        117059     117059           
===========================================
  Hits          93572      93572           
  Misses        16133      16133           
  Partials       7354       7354

@qw4990 qw4990 requested a review from zz-jason November 22, 2019 07:34
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

util/execdetails/execdetails.go Outdated Show resolved Hide resolved
Co-Authored-By: Zhang Jian <zjsariel@gmail.com>
Copy link
Member

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Nov 23, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 23, 2019

/run-all-tests

@sre-bot sre-bot merged commit bc21efe into pingcap:master Nov 23, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants