Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix the bug that VIEWs can be dropped by DROP TABLE syntax #14048

Merged
merged 5 commits into from Dec 13, 2019
Merged

ddl: fix the bug that VIEWs can be dropped by DROP TABLE syntax #14048

merged 5 commits into from Dec 13, 2019

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Dec 13, 2019

What problem does this PR solve?

This PR tries to close #14047

What is changed and how it works?

Add missing checks

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • NA

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the bug that VIEWs can be dropped by DROP TABLE syntax

@bb7133 bb7133 requested a review from zimulala December 13, 2019 03:59
@bb7133
Copy link
Member Author

bb7133 commented Dec 13, 2019

/run-unit-test

@codecov
Copy link

codecov bot commented Dec 13, 2019 •
edited

Codecov Report

Merging #14048 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #14048   +/-   ##
===========================================
  Coverage   80.2145%   80.2145%           
===========================================
  Files           483        483           
  Lines        121362     121362           
===========================================
  Hits          97350      97350           
  Misses        16279      16279           
  Partials       7733       7733

@bb7133
Copy link
Member Author

bb7133 commented Dec 13, 2019

/run-all-tests

wjhuang2016
wjhuang2016 reviewed Dec 13, 2019
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

djshow832
djshow832 reviewed Dec 13, 2019
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djshow832 djshow832 added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 13, 2019
crazycs520
crazycs520 approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT3 The PR has already had 3 LGTM. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Dec 13, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 13, 2019

/run-all-tests

@sre-bot sre-bot merged commit 3ee6bc8 into pingcap:master Dec 13, 2019
@sre-bot sre-bot mentioned this pull request Dec 13, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Dec 13, 2019

cherry pick to release-3.0 in PR #14052

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@bb7133 @XiaTianliang
ddl: fix the bug that VIEWs can be dropped by DROP TABLE syntax (pi…
56db7f1 
…ngcap#14048)
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
@bb7133 bb7133 deleted the bb7133/fix_14047 branch December 29, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@djshow832 djshow832 djshow832 left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ddl: VIEWs can be dropped by DROP TABLE syntax
6 participants
@bb7133 @sre-bot @wjhuang2016 @crazycs520 @djshow832 @you06