Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Reorganize partition supporting global index #53277

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented May 14, 2024

What problem does this PR solve?

Issue Number: ref #45133
REORGANIZE PARTITION is not allowed for tables with GLOBAL INDEX

Problem Summary:
This was disabled, since Global index was not stable. Now when we are stabilizing Global index, this is a functionality blocker.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 14, 2024
Copy link

tiprow bot commented May 14, 2024

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 87.20379% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 74.5432%. Comparing base (87999d1) to head (bdca845).
Report is 21 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53277        +/-   ##
================================================
+ Coverage   74.4295%   74.5432%   +0.1136%     
================================================
  Files          1506       1506                
  Lines        357522     431771     +74249     
================================================
+ Hits         266102     321856     +55754     
- Misses        71987      90002     +18015     
- Partials      19433      19913       +480     
Flag Coverage Δ
integration 49.1752% <84.8341%> (?)
unit 71.4485% <85.7819%> (-1.8537%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 50.4606% <ø> (+6.9284%) ⬆️

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 18, 2024
pkg/ddl/ddl_api.go Outdated Show resolved Hide resolved
pkg/ddl/partition.go Outdated Show resolved Hide resolved
tests/integrationtest/t/ddl/integration.test Show resolved Hide resolved
@mjonss
Copy link
Contributor Author

mjonss commented May 20, 2024

Try SQL below, reports a error.
...

Nice catch, I fixed it and added the test to the integration test.

@Defined2014
Copy link
Contributor

/retest

Copy link
Contributor

@Defined2014 Defined2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny comments, reset LGTM

pkg/ddl/ddl_api.go Outdated Show resolved Hide resolved
pkg/ddl/partition.go Outdated Show resolved Hide resolved
@mjonss
Copy link
Contributor Author

mjonss commented May 29, 2024

/retest

@AilinKid
Copy link
Contributor

great work, it seems most of this pull request is related to the DDL module, I'm not quite familiar with this part. @zimulala @tangenta

Copy link

ti-chi-bot bot commented Jun 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Defined2014, jiyfhust
Once this PR has been reviewed and has the lgtm label, please assign ywqzzy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jun 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-22 05:36:12.752758477 +0000 UTC m=+2236326.509894051: ☑️ agreed by Defined2014.
  • 2024-06-01 15:01:29.416205018 +0000 UTC m=+3134243.173340591: ☑️ agreed by jiyfhust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm ok-to-test release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants