-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Reorganize partition supporting global index #53277
base: master
Are you sure you want to change the base?
Conversation
Hi @mjonss. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53277 +/- ##
================================================
+ Coverage 74.4295% 74.5432% +0.1136%
================================================
Files 1506 1506
Lines 357522 431771 +74249
================================================
+ Hits 266102 321856 +55754
- Misses 71987 90002 +18015
- Partials 19433 19913 +480
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
Nice catch, I fixed it and added the test to the integration test. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two tiny comments, reset LGTM
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Defined2014, jiyfhust The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #45133
REORGANIZE PARTITION is not allowed for tables with GLOBAL INDEX
Problem Summary:
This was disabled, since Global index was not stable. Now when we are stabilizing Global index, this is a functionality blocker.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.